-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62465/
-----------------------------------------------------------

(Updated Sept. 21, 2017, 8:29 p.m.)


Review request for Ambari, Balázs Bence Sári, Jonathan Hurley, and Nate Cole.


Changes
-------

unit test coverage


Bugs: AMBARI-22025
    https://issues.apache.org/jira/browse/AMBARI-22025


Repository: ambari


Description
-------

Execution commands embedded in status commands are created programmatically 
instead of deserializing JSON.  AMBARI-21361 centralized addition of 
`service_package_folder` and `hooks_folder`, but the logic is not executed in 
this case.

Fix: reuse the logic (extracted to the method `setVersions`) which adds 
`service_package_folder` and a few other parameters.

(patch is for branch-2.6)


Diffs (updated)
-----

  
ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ExecutionCommandWrapper.java
 7b202598d5bb88d78dc8486ed2801f87efb326a8 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
 96ed2613888c1badc50c21f540868444e5698b51 
  
ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatMonitor.java
 61e322f71a373c0e3c69d44b89ef0b270aa6a85c 


Diff: https://reviews.apache.org/r/62465/diff/2/

Changes: https://reviews.apache.org/r/62465/diff/1-2/


Testing
-------

* Tested manually on local cluster per STR.
* Unit tests: `Tests run: 4909, Failures: 0, Errors: 0, Skipped: 34`


Thanks,

Attila Doroszlai

Reply via email to