-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62474/
-----------------------------------------------------------

(Updated Sept. 21, 2017, 7:57 p.m.)


Review request for Ambari, Aravindan Vijayan, Dmytro Sen, and Jaimin Jetly.


Changes
-------

Fixes based on comments.


Bugs: AMBARI-22034
    https://issues.apache.org/jira/browse/AMBARI-22034


Repository: ambari


Description
-------

Mode, memory and some other settings are hard to hand edit and can use some 
better UI tooling.


Diffs (updated)
-----

  
ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TimelineMetricConfiguration.java
 44073ab 
  
ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TimelineMetricsFilter.java
 1446ec2 
  
ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TimelineMetricsFilterTest.java
 81da5c8 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-env.xml
 4d33661 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-hbase-env.xml
 9c4fc02 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-hbase-site.xml
 2c9378e 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-site.xml
 1b085f6 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/metainfo.xml
 43c3685 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/themes/theme.json
 PRE-CREATION 


Diff: https://reviews.apache.org/r/62474/diff/2/

Changes: https://reviews.apache.org/r/62474/diff/1-2/


Testing
-------

Manually tested.


Thanks,

Sid Wagle

Reply via email to