----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62501/#review185968 -----------------------------------------------------------
Ship it! Ship It! - Dmytro Sen On Sept. 22, 2017, 11:02 a.m., Andrew Onischuk wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62501/ > ----------------------------------------------------------- > > (Updated Sept. 22, 2017, 11:02 a.m.) > > > Review request for Ambari and Dmytro Sen. > > > Bugs: AMBARI-22040 > https://issues.apache.org/jira/browse/AMBARI-22040 > > > Repository: ambari > > > Description > ------- > > configs.py is used by users and support folks for modifying > configurations. While this works well for getting and setting individual > properties, it does not work well for dealing with json files. This is needed > for edits to *env.sh or stack_features. > > _Current behavior_: > > * Exporting ams-grafana-env does not give a properly formatted json file > * Cannot use a get change the json and set it back. > > The expected behavior is to let the user modify the json file and re-import it > into the cluster. > > > Diffs > ----- > > ambari-server/src/main/resources/scripts/configs.py 639f28e > ambari-server/src/main/resources/scripts/configs.sh 5fc96fd > > > Diff: https://reviews.apache.org/r/62501/diff/1/ > > > Testing > ------- > > mvn clean test > > > Thanks, > > Andrew Onischuk > >
