----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62550/#review186145 -----------------------------------------------------------
Ship it! ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java Line 186 (original), 186 (patched) <https://reviews.apache.org/r/62550/#comment262581> Sigh ... we need to document this in a follow-up Jira. I'll create one as part of the effort to get other providers to be guice-injected... ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java Line 450 (original), 451 (patched) <https://reviews.apache.org/r/62550/#comment262582> Now that this @Transactional is being picked up, you shouldn't need this, right? The following statement in the AmbariJpaLocalTxnInterceptor should handle it? ``` if (txn.getRollbackOnly()) { txn.rollback(); return false; } ``` - Jonathan Hurley On Sept. 25, 2017, 2:17 p.m., Nate Cole wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62550/ > ----------------------------------------------------------- > > (Updated Sept. 25, 2017, 2:17 p.m.) > > > Review request for Ambari, Dmitro Lisnichenko, Jonathan Hurley, and Sid Wagle. > > > Bugs: AMBARI-22014 > https://issues.apache.org/jira/browse/AMBARI-22014 > > > Repository: ambari > > > Description > ------- > > The resource provider was not being created via injection, so all the > @Transactional annotations were not being honored. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java > 53c10c3298 > > ambari-server/src/main/java/org/apache/ambari/server/controller/ResourceProviderFactory.java > 9f9eaeef61 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java > 77e6250084 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java > a1e07dc313 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/DefaultProviderModule.java > 35fdcf631f > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProviderTest.java > 7ad3a87db5 > > > Diff: https://reviews.apache.org/r/62550/diff/1/ > > > Testing > ------- > > Manual. Unit tests pending. > > > Thanks, > > Nate Cole > >
