> On Sept. 26, 2017, 10:14 a.m., Attila Doroszlai wrote: > > ambari-server/src/main/java/org/apache/ambari/server/events/listeners/alerts/AlertReceivedListener.java > > Line 170 (original), 174 (patched) > > <https://reviews.apache.org/r/62563/diff/1/?file=1835316#file1835316line180> > > > > This null check should precede usage of `definition`.
thanks Attila. Fixed it. - Andrew ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62563/#review186227 ----------------------------------------------------------- On Sept. 26, 2017, 10:58 a.m., Andrew Onischuk wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62563/ > ----------------------------------------------------------- > > (Updated Sept. 26, 2017, 10:58 a.m.) > > > Review request for Ambari, Attila Doroszlai, Myroslav Papirkovskyy, and Sid > Wagle. > > > Bugs: AMBARI-22057 > https://issues.apache.org/jira/browse/AMBARI-22057 > > > Repository: ambari > > > Description > ------- > > 1\. Send alerts only if status or text changed. This reduces bandwidth usage > and number of operations (DB and others) done by server. > 2\. Don't send some redundant fields in alert reports. This reduces bandwidth > usage. > > > Diffs > ----- > > ambari-agent/src/main/python/ambari_agent/AlertStatusReporter.py 3d5a62e > ambari-agent/src/main/python/ambari_agent/ClusterCache.py 7704443 > ambari-agent/src/main/python/ambari_agent/alerts/base_alert.py e364447 > > ambari-server/src/main/java/org/apache/ambari/server/events/listeners/alerts/AlertReceivedListener.java > 3607df4 > > > Diff: https://reviews.apache.org/r/62563/diff/3/ > > > Testing > ------- > > mvn clean test > > > Thanks, > > Andrew Onischuk > >
