> On Sept. 27, 2017, 12:20 a.m., Madhuvanthi Radhakrishnan wrote: > > Hi Vitaly, > > Kindly refer https://reviews.apache.org/r/56727/ to check the value of > > user_groups attribute. > > For eg: > > /resources/common-services/ZEPPELIN/0.6.0.2.5/configuration/zeppelin-env.xml > > <property> > > <name>zeppelin_user</name> > > <value>zeppelin</value> > > <property-type>USER</property-type> > > <description>User zeppelin daemon runs as</description> > > <value-attributes> > > <type>user</type> > > <overridable>false</overridable> > > <user-group> > > <property> > > <type>zeppelin-env</type> > > <name>zeppelin_group</name> > > </property> > > <property> > > <type>hadoop-env</type> > > <name>proxyuser_group</name> > > </property> > > </user-group> > > </value-attributes> > > <on-ambari-upgrade add="true"/> > > </property> > > > > Here, the user-group tag is able to tell the mapping between > > (zeppelin_group property in zeppellin-env file and proxyuser_group property > > in hadoop-env file) with the zeppelin_user. > > You can follow a similar pattern for the other services. > > Thanks for doing this. > > Jayush Luniya wrote: > @Madhu > I think we renamed <user-group> to <user-groups> in the final patch. Can > you confirm? > > Vitalyi Brodetskyi wrote: > Jayush, you are right. I've tested my patch and it works with > <user-groups>
Yes Jayush, my bad it is user-groups. I wanted to point out the <type> and <name> tags within the <user-groups> - Madhuvanthi ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62599/#review186348 ----------------------------------------------------------- On Sept. 26, 2017, 11:23 p.m., Vitalyi Brodetskyi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62599/ > ----------------------------------------------------------- > > (Updated Sept. 26, 2017, 11:23 p.m.) > > > Review request for Ambari, Jayush Luniya and Madhuvanthi Radhakrishnan. > > > Bugs: AMBARI-22068 > https://issues.apache.org/jira/browse/AMBARI-22068 > > > Repository: ambari > > > Description > ------- > > We added feature to tag a user property with corresponding user-group > properties to which a user should be added. We no longer should need the > hardcoded logic in the hooks adding users to groups. This can be entirely > stack driven after we update the user config properties for all services. > > > Diffs > ----- > > > ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/configuration/accumulo-env.xml > e4aa21e > > ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/configuration/infra-solr-env.xml > 52a5e6a > > ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-env.xml > 4d33661 > > ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/configuration/atlas-env.xml > 74d8600 > > ambari-server/src/main/resources/common-services/ATLAS/0.7.0.3.0/configuration/atlas-env.xml > f97ca98 > > ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-env.xml > 23b82e3 > > ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/configuration/falcon-env.xml > f45199f > > ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/configuration/flume-env.xml > ccbda1e > > ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/configuration/hbase-env.xml > 6393659 > > ambari-server/src/main/resources/common-services/HBASE/2.0.0.3.0/configuration/hbase-env.xml > 733ca8b > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/configuration/hadoop-env.xml > bb671cc > > ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/configuration/hadoop-env.xml > e292e6e > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-env.xml > b2c364c > > ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/configuration/hive-env.xml > 54a62e2 > > ambari-server/src/main/resources/common-services/KAFKA/0.10.0.3.0/configuration/kafka-env.xml > 90ba1c8 > > ambari-server/src/main/resources/common-services/KAFKA/0.8.1/configuration/kafka-env.xml > ad81d66 > > ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/configuration/knox-env.xml > 680e81f > > ambari-server/src/main/resources/common-services/KNOX/0.5.0.3.0/configuration/knox-env.xml > e1ca45a > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-env.xml > e861b6e > > ambari-server/src/main/resources/common-services/MAHOUT/1.0.0.2.3/configuration/mahout-env.xml > b2d60c6 > > ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/configuration/oozie-env.xml > 7748176 > > ambari-server/src/main/resources/common-services/OOZIE/4.2.0.3.0/configuration/oozie-env.xml > 0f67356 > > ambari-server/src/main/resources/common-services/RANGER/0.4.0/configuration/ranger-env.xml > cc62c8b > > ambari-server/src/main/resources/common-services/RANGER/1.0.0.3.0/configuration/ranger-env.xml > ff44901 > > ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/configuration/kms-env.xml > e5c0673 > > ambari-server/src/main/resources/common-services/RANGER_KMS/1.0.0.3.0/configuration/kms-env.xml > acecdfe > > ambari-server/src/main/resources/common-services/SPARK/1.2.1/configuration/spark-env.xml > 55d67cc > > ambari-server/src/main/resources/common-services/SPARK/2.2.0/configuration/livy-env.xml > cec8054 > > ambari-server/src/main/resources/common-services/SPARK/2.2.0/configuration/spark-env.xml > f980f9a > > ambari-server/src/main/resources/common-services/SPARK2/2.0.0/configuration/spark2-env.xml > 35d364f > > ambari-server/src/main/resources/common-services/SQOOP/1.4.4.2.0/configuration/sqoop-env.xml > d9d548d > > ambari-server/src/main/resources/common-services/SQOOP/1.4.4.3.0/configuration/sqoop-env.xml > 6e16ab33 > > ambari-server/src/main/resources/common-services/STORM/0.9.1/configuration/storm-env.xml > 3d4edad > > ambari-server/src/main/resources/common-services/STORM/1.0.1.3.0/configuration/storm-env.xml > 3ee0602 > > ambari-server/src/main/resources/common-services/SUPERSET/0.15.0/configuration/superset-env.xml > 71fa3b6 > > ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/configuration/tez-env.xml > 6a3b7ef > > ambari-server/src/main/resources/common-services/TEZ/0.9.0.3.0/configuration/tez-env.xml > 649aa68 > > ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/configuration-mapred/mapred-env.xml > fe6d4b9 > > ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/configuration/yarn-env.xml > c3bbcb6 > > ambari-server/src/main/resources/common-services/YARN/3.0.0.3.0/configuration-mapred/mapred-env.xml > 93e5234 > > ambari-server/src/main/resources/common-services/YARN/3.0.0.3.0/configuration/yarn-env.xml > 4e722ee > > ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0/configuration/zeppelin-env.xml > fb3b512 > > ambari-server/src/main/resources/common-services/ZEPPELIN/0.7.0/configuration/zeppelin-env.xml > 85373e0 > > ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5/configuration/zookeeper-env.xml > 5a1529d > > ambari-server/src/main/resources/stacks/HDP/2.0.6/configuration/cluster-env.xml > 55b9cd3 > > ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-ANY/scripts/params.py > 4d92dbe > > ambari-server/src/main/resources/stacks/HDP/2.2/services/HBASE/configuration/hbase-env.xml > 5bd1017 > > ambari-server/src/main/resources/stacks/HDP/2.5/services/ATLAS/configuration/atlas-env.xml > ebebf82 > > ambari-server/src/main/resources/stacks/HDP/2.5/services/SPARK/configuration/livy-env.xml > fee24bb > > ambari-server/src/main/resources/stacks/HDP/2.6/services/SPARK/configuration/livy-env.xml > 23a4cc1 > > ambari-server/src/main/resources/stacks/HDP/2.6/services/ZEPPELIN/configuration/zeppelin-env.xml > 94b1d57 > > ambari-server/src/main/resources/stacks/HDP/3.0/configuration/cluster-env.xml > 1b903b1 > > ambari-server/src/main/resources/stacks/HDP/3.0/hooks/before-ANY/scripts/params.py > eb5feae > > > Diff: https://reviews.apache.org/r/62599/diff/1/ > > > Testing > ------- > > mvn clean test > > > Thanks, > > Vitalyi Brodetskyi > >
