> On Sept. 29, 2017, 3:18 a.m., Dmitro Lisnichenko wrote: > > ambari-server/src/main/java/org/apache/ambari/server/agent/StatusCommand.java > > Lines 43 (patched) > > <https://reviews.apache.org/r/62675/diff/1/?file=1839249#file1839249line46> > > > > How it differs from componentName? > > Jonathan Hurley wrote: > It doesn't - normal execution commands use "role" but status commands use > "componentName". I actually prefer "componentName", but maybe we did this > because a "role" could also not be a component name. > > However, the Python code would just get more complicated if we have to > start double-checking for componentName & role everywhere, so I just decided > to make it easy and add it to this command as well. I'll doc this so others > understand why it was added.
It's fine for python code to make this easier, but why not just set "role" (the field) when setting componentName? That way at least the java side stays "pure" without having to remember to set both (even though it looks like there's just one setter call). - Nate ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62675/#review186647 ----------------------------------------------------------- On Sept. 28, 2017, 2:27 p.m., Jonathan Hurley wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62675/ > ----------------------------------------------------------- > > (Updated Sept. 28, 2017, 2:27 p.m.) > > > Review request for Ambari, Dmitro Lisnichenko, Nate Cole, and Robert Levas. > > > Bugs: AMBARI-22083 > https://issues.apache.org/jira/browse/AMBARI-22083 > > > Repository: ambari > > > Description > ------- > > STR: > > - Install HDP 2.6.0.0 with HDFS and YARN/MapR > - Perform a MAINT upgrade of HDFS to 2.6.3.0 > - Stop all services > - Restart all services > > The following is observed: > - {{/usr/hdp/current/hadoop-client -> /usr/hdp/2.6.0.0/hadoop}} > - HDFS picks up 2.6.0.0 > - YARN/MapR pick up 2.6.0.0 > > The upgraded components should pickup the version of the hadoop home > directory that is theirs. > > > Diffs > ----- > > > ambari-common/src/main/python/resource_management/libraries/functions/component_version.py > a1fd6b2e7c > > ambari-common/src/main/python/resource_management/libraries/functions/conf_select.py > ffcaad5cbc > > ambari-common/src/main/python/resource_management/libraries/functions/stack_select.py > f5068e4295 > > ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatMonitor.java > 0042f53c7e > > ambari-server/src/main/java/org/apache/ambari/server/agent/StatusCommand.java > 5dec53c32f > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py > 77e1bed96f > > ambari-server/src/main/resources/stacks/BigInsights/4.0/hooks/after-INSTALL/scripts/params.py > d3332db3af > > ambari-server/src/main/resources/stacks/BigInsights/4.0/hooks/before-ANY/scripts/params.py > 5ffd28ca94 > > ambari-server/src/main/resources/stacks/BigInsights/4.0/hooks/before-START/scripts/params.py > 5c84a05b0d > > ambari-server/src/main/resources/stacks/BigInsights/4.2.5/hooks/after-INSTALL/scripts/params.py > c4970543d6 > > ambari-server/src/main/resources/stacks/BigInsights/4.2.5/hooks/before-ANY/scripts/params.py > b0467a9a75 > > ambari-server/src/main/resources/stacks/BigInsights/4.2.5/hooks/before-START/scripts/params.py > be9db58fef > > ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/after-INSTALL/scripts/params.py > 4d7eaee3b9 > > ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-ANY/scripts/params.py > 1fd7f3ef76 > > ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-ANY/scripts/shared_initialization.py > 3997117ade > > ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/params.py > 5ca2d94403 > > ambari-server/src/main/resources/stacks/HDP/2.3.ECS/services/ECS/package/scripts/params.py > c304a93b5e > > ambari-server/src/test/python/stacks/2.0.6/hooks/before-ANY/test_before_any.py > 9dceb69fee > > > Diff: https://reviews.apache.org/r/62675/diff/1/ > > > Testing > ------- > > End-to-End manual tests > Lots of Python test fixes PENDING... > > > Thanks, > > Jonathan Hurley > >
