-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62726/
-----------------------------------------------------------
Review request for Ambari, Dmitro Lisnichenko and Jonathan Hurley.
Bugs: AMBARI-22110
https://issues.apache.org/jira/browse/AMBARI-22110
Repository: ambari
Description
-------
While investigating an issue with VDFs which don't contain any OS's which match
the cluster, it was observed that, even after throwing an Exception inside of a
Transaction, the entities created inside that transaction were being committed.
Eventual investigation led to a problem between Guice/AOP and our
ResourceProviders. The Guice documentations says that @Transactional methods
can only be intercepted on objects created by Guice:
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java
e3f1458202
ambari-server/src/main/java/org/apache/ambari/server/controller/ResourceProviderFactory.java
9cd1d745c6
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java
0782685d07
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertTargetResourceProvider.java
0b7f1db9c9
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProvider.java
9d2b39effc
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/DefaultProviderModule.java
781b01525f
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ViewInstanceResourceProvider.java
63e6c24fc8
Diff: https://reviews.apache.org/r/62726/diff/1/
Testing
-------
Manual. Automated pending.
Thanks,
Nate Cole
