----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62723/#review186850 -----------------------------------------------------------
Ship it! Ship It! - Sebastian Toader On Oct. 2, 2017, 2:04 p.m., Attila Doroszlai wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62723/ > ----------------------------------------------------------- > > (Updated Oct. 2, 2017, 2:04 p.m.) > > > Review request for Ambari, Andrew Onischuk, Oliver Szabo, Sebastian Toader, > and Vitalyi Brodetskyi. > > > Repository: ambari > > > Description > ------- > > Eliminate/tweak Python 2.7+ constructs: > > * multiple contexts in `with` > * `assertIsNone` > * `assertRaises` > * `unittest.util` > > > Diffs > ----- > > > ambari-common/src/main/python/resource_management/libraries/functions/conf_select.py > 86821bf47a757284f02ed5049fb29ccb71451340 > ambari-server/src/test/python/TestUpgradeSummary.py > 7606867f87f580e081c466ec889a6baa122b6c7a > > ambari-server/src/test/python/common-services/HIVE/test_jdbc_driver_config.py > e4d81b1bf650e15ac730c0e5d889ba2f98c32308 > > ambari-server/src/test/python/common-services/RANGER/test_db_flavor_config.py > 568e3fd7bb99ba888755382bce89065ea7d40914 > > ambari-server/src/test/python/common-services/RANGER_KMS/test_db_flavor_config.py > 48654ee18ad80aed35c3cab3d1ccbe6783be6b43 > > ambari-server/src/test/python/common-services/SQOOP/test_jdbc_driver_config.py > 7bb809a0a4e04565a1b201f08db8e0a93c3fd42c > ambari-server/src/test/python/stacks/2.3/common/test_stack_advisor.py > 0cc9ad0a603f5988e7f3af76babc9ad677c58149 > ambari-server/src/test/python/stacks/utils/RMFTestCase.py > 291f22b0fb1907cda4df4276aeff8a9df6d32b30 > > > Diff: https://reviews.apache.org/r/62723/diff/1/ > > > Testing > ------- > > Tested with Python 2.6: > > ``` > $ mvn -am -pl ambari-server,ambari-agent -Drat.skip -Dcheckstyle.skip > -DskipSurefireTests clean test > ... > Total run:1202 > Total errors:0 > Total failures:0 > ... > Ran 454 tests in 22.430s > ... > [INFO] Ambari Server ...................................... FAILURE [01:41 > min] > [INFO] Ambari Agent ....................................... SUCCESS [ 28.188 > s] > ... > ``` > > and Python 2.7: > > ``` > $ mvn -am -pl ambari-server,ambari-agent -Drat.skip -Dcheckstyle.skip > -DskipSurefireTests clean test > ... > Total run:1202 > Total errors:0 > Total failures:0 > ... > Ran 457 tests in 16.645s > ... > [INFO] Ambari Server ...................................... SUCCESS [01:35 > min] > [INFO] Ambari Agent ....................................... SUCCESS [ 20.611 > s] > ``` > > > Thanks, > > Attila Doroszlai > >
