-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62725/
-----------------------------------------------------------
(Updated Oct. 3, 2017, 3:11 p.m.)
Review request for Ambari, Andrii Babiichuk and Oliver Szabo.
Bugs: AMBARI-22109
https://issues.apache.org/jira/browse/AMBARI-22109
Repository: ambari
Description
-------
The html sctructure should be more simple with less 'a' tag and handling the
button's element as one component. It should be optimized with less event
listeners and html element.
Diffs
-----
ambari-logsearch/ambari-logsearch-web/src/app/components/accordion-panel/accordion-panel.component.less
8366952
ambari-logsearch/ambari-logsearch-web/src/app/components/app.component.less
d1aa7ff
ambari-logsearch/ambari-logsearch-web/src/app/components/dropdown-button/dropdown-button.component.less
a5da7f5
ambari-logsearch/ambari-logsearch-web/src/app/components/dropdown-list/dropdown-list.component.less
6faa192
ambari-logsearch/ambari-logsearch-web/src/app/components/filters-panel/filters-panel.component.html
fc3dac8
ambari-logsearch/ambari-logsearch-web/src/app/components/filters-panel/filters-panel.component.less
4607d34
ambari-logsearch/ambari-logsearch-web/src/app/components/log-file-entry/log-file-entry.component.less
d3523d3
ambari-logsearch/ambari-logsearch-web/src/app/components/logs-list/logs-list.component.less
0fded67
ambari-logsearch/ambari-logsearch-web/src/app/components/main-container/main-container.component.less
f7dcc05
ambari-logsearch/ambari-logsearch-web/src/app/components/menu-button/menu-button.component.html
ca70927
ambari-logsearch/ambari-logsearch-web/src/app/components/menu-button/menu-button.component.less
6a3a43d
ambari-logsearch/ambari-logsearch-web/src/app/components/mixins.less
PRE-CREATION
ambari-logsearch/ambari-logsearch-web/src/app/components/pagination-controls/pagination-controls.component.less
8238eaf
ambari-logsearch/ambari-logsearch-web/src/app/components/pagination/pagination.component.less
df8ad2d
ambari-logsearch/ambari-logsearch-web/src/app/components/search-box/search-box.component.less
6d4378b
ambari-logsearch/ambari-logsearch-web/src/app/components/time-range-picker/time-range-picker.component.less
7d45778
ambari-logsearch/ambari-logsearch-web/src/app/components/top-menu/top-menu.component.less
e5e85f4
ambari-logsearch/ambari-logsearch-web/src/app/components/variables.less
2dc6278
Diff: https://reviews.apache.org/r/62725/diff/2/
Testing
-------
Manual testing (yarn build, yarn start, yarn test, mvn clean package)
**mvn clean package**
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 01:47 min
[INFO] Finished at: 2017-10-02T17:54:23+02:00
[INFO] Final Memory: 19M/65M
[INFO] ------------------------------------------------------------------------
**yarn build**
? Done in 23.45s.
**yarn test**
PhantomJS 2.1.1 (Mac OS X 0.0.0): Executed 89 of 89 SUCCESS (2.405 secs / 2.393
secs)
? Done in 25.90s.
Thanks,
Istvan Tobias
