----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62754/ -----------------------------------------------------------
Review request for Ambari, Dmytro Grinenko, Dmitro Lisnichenko, and Nate Cole. Bugs: AMBARI-22123 https://issues.apache.org/jira/browse/AMBARI-22123 Repository: ambari Description ------- Essentially, the symlinking was doing a quick-exit if the /etc/<component>/conf directory already existed. However, it might have been created by another RPM and not the component we actually care about. The refactor here did two things: - Invokes conf-select on the necessary packages - Combined most of the logic between conf_select.select(...) and conf_select.convert_conf_directories_to_symlinks(...) - Removed legacy code from back in the pre-HDP 2.3 days Diffs ----- ambari-common/src/main/python/resource_management/libraries/functions/conf_select.py 86821bf47a ambari-server/src/main/resources/custom_actions/scripts/install_packages.py 3ace3b1570 ambari-server/src/main/resources/stacks/BigInsights/4.0/services/ZOOKEEPER/package/scripts/zookeeper_service.py 0727970adb ambari-server/src/main/resources/stacks/BigInsights/4.2/services/ZOOKEEPER/package/scripts/zookeeper_service.py 0727970adb ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/after-INSTALL/scripts/shared_initialization.py 20fd48de15 contrib/management-packs/odpi-ambari-mpack/src/main/resources/stacks/ODPi/2.0/services/HIVE/package/scripts/hive_client.py 3d9bfd7c3e contrib/management-packs/odpi-ambari-mpack/src/main/resources/stacks/ODPi/2.0/services/HIVE/package/scripts/hive_metastore.py b88f3858a7 contrib/management-packs/odpi-ambari-mpack/src/main/resources/stacks/ODPi/2.0/services/HIVE/package/scripts/hive_server.py 31b083bd0d contrib/management-packs/odpi-ambari-mpack/src/main/resources/stacks/ODPi/2.0/services/HIVE/package/scripts/hive_server_interactive.py 2df001cf21 contrib/management-packs/odpi-ambari-mpack/src/main/resources/stacks/ODPi/2.0/services/HIVE/package/scripts/webhcat_server.py 34687c453b contrib/management-packs/odpi-ambari-mpack/src/main/resources/stacks/ODPi/2.0/services/YARN/package/scripts/application_timeline_server.py 4ec6aa788f contrib/management-packs/odpi-ambari-mpack/src/main/resources/stacks/ODPi/2.0/services/YARN/package/scripts/historyserver.py 34c683ab2f contrib/management-packs/odpi-ambari-mpack/src/main/resources/stacks/ODPi/2.0/services/YARN/package/scripts/mapreduce2_client.py 424157b128 contrib/management-packs/odpi-ambari-mpack/src/main/resources/stacks/ODPi/2.0/services/YARN/package/scripts/nodemanager.py b235cad164 contrib/management-packs/odpi-ambari-mpack/src/main/resources/stacks/ODPi/2.0/services/YARN/package/scripts/resourcemanager.py 71c7bc17a2 contrib/management-packs/odpi-ambari-mpack/src/main/resources/stacks/ODPi/2.0/services/YARN/package/scripts/yarn_client.py 4d65a404a2 Diff: https://reviews.apache.org/r/62754/diff/1/ Testing ------- PENDING... Thanks, Jonathan Hurley