----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62770/#review187085 -----------------------------------------------------------
Ship it! Ship It! - Andrii Tkach On Oct. 4, 2017, 12:44 p.m., Andrii Babiichuk wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62770/ > ----------------------------------------------------------- > > (Updated Oct. 4, 2017, 12:44 p.m.) > > > Review request for Ambari and Andrii Tkach. > > > Bugs: AMBARI-22129 > https://issues.apache.org/jira/browse/AMBARI-22129 > > > Repository: ambari > > > Description > ------- > > Locate model classes and other ones in one directory to avoid confusion, > since model classes can be used not only in storage-related code. > > > Diffs > ----- > > > ambari-logsearch/ambari-logsearch-web/src/app/classes/active-service-log-entry.class.ts > d3d7d95 > > ambari-logsearch/ambari-logsearch-web/src/app/classes/active-service-log-entry.ts > PRE-CREATION > > ambari-logsearch/ambari-logsearch-web/src/app/classes/histogram-options.class.ts > dee5d98 > ambari-logsearch/ambari-logsearch-web/src/app/classes/histogram-options.ts > PRE-CREATION > ambari-logsearch/ambari-logsearch-web/src/app/classes/list-item.class.ts > 1aaaecc > ambari-logsearch/ambari-logsearch-web/src/app/classes/list-item.ts > PRE-CREATION > > ambari-logsearch/ambari-logsearch-web/src/app/classes/models/app-settings.ts > PRE-CREATION > ambari-logsearch/ambari-logsearch-web/src/app/classes/models/app-state.ts > PRE-CREATION > > ambari-logsearch/ambari-logsearch-web/src/app/classes/models/audit-log-field.ts > PRE-CREATION > ambari-logsearch/ambari-logsearch-web/src/app/classes/models/audit-log.ts > PRE-CREATION > ambari-logsearch/ambari-logsearch-web/src/app/classes/models/bar-graph.ts > PRE-CREATION > > ambari-logsearch/ambari-logsearch-web/src/app/classes/models/common-entry.ts > PRE-CREATION > ambari-logsearch/ambari-logsearch-web/src/app/classes/models/count.ts > PRE-CREATION > ambari-logsearch/ambari-logsearch-web/src/app/classes/models/filter.ts > PRE-CREATION > ambari-logsearch/ambari-logsearch-web/src/app/classes/models/graph.ts > PRE-CREATION > ambari-logsearch/ambari-logsearch-web/src/app/classes/models/log-field.ts > PRE-CREATION > ambari-logsearch/ambari-logsearch-web/src/app/classes/models/log.ts > PRE-CREATION > ambari-logsearch/ambari-logsearch-web/src/app/classes/models/node.ts > PRE-CREATION > > ambari-logsearch/ambari-logsearch-web/src/app/classes/models/service-log-field.ts > PRE-CREATION > ambari-logsearch/ambari-logsearch-web/src/app/classes/models/service-log.ts > PRE-CREATION > > ambari-logsearch/ambari-logsearch-web/src/app/classes/models/solr-collection-state.ts > PRE-CREATION > ambari-logsearch/ambari-logsearch-web/src/app/classes/models/store.ts > PRE-CREATION > ambari-logsearch/ambari-logsearch-web/src/app/classes/models/user-config.ts > PRE-CREATION > > ambari-logsearch/ambari-logsearch-web/src/app/classes/queries/audit-logs-query-params.class.ts > 3727abb > > ambari-logsearch/ambari-logsearch-web/src/app/classes/queries/audit-logs-query-params.ts > PRE-CREATION > > ambari-logsearch/ambari-logsearch-web/src/app/classes/queries/query-params.class.ts > 83c3261 > > ambari-logsearch/ambari-logsearch-web/src/app/classes/queries/query-params.ts > PRE-CREATION > > ambari-logsearch/ambari-logsearch-web/src/app/classes/queries/service-logs-histogram-query-params.class.spec.ts > efa2459 > > ambari-logsearch/ambari-logsearch-web/src/app/classes/queries/service-logs-histogram-query-params.class.ts > 2e2113f > > ambari-logsearch/ambari-logsearch-web/src/app/classes/queries/service-logs-histogram-query-params.spec.ts > PRE-CREATION > > ambari-logsearch/ambari-logsearch-web/src/app/classes/queries/service-logs-histogram-query-params.ts > PRE-CREATION > > ambari-logsearch/ambari-logsearch-web/src/app/classes/queries/service-logs-query-params.class.ts > 864b689 > > ambari-logsearch/ambari-logsearch-web/src/app/classes/queries/service-logs-query-params.ts > PRE-CREATION > > ambari-logsearch/ambari-logsearch-web/src/app/classes/queries/service-logs-truncated-query-params.class.ts > da05cee > > ambari-logsearch/ambari-logsearch-web/src/app/classes/queries/service-logs-truncated-query-params.ts > PRE-CREATION > > ambari-logsearch/ambari-logsearch-web/src/app/classes/service-log-context-entry.class.ts > 15c05fb > > ambari-logsearch/ambari-logsearch-web/src/app/classes/service-log-context-entry.ts > PRE-CREATION > > ambari-logsearch/ambari-logsearch-web/src/app/components/dropdown-button/dropdown-button.component.ts > 43d79f8 > > ambari-logsearch/ambari-logsearch-web/src/app/components/dropdown-list/dropdown-list.component.ts > 656c901 > > ambari-logsearch/ambari-logsearch-web/src/app/components/filter-button/filter-button.component.ts > 1481583 > > ambari-logsearch/ambari-logsearch-web/src/app/components/filters-panel/filters-panel.component.ts > c345c81 > > ambari-logsearch/ambari-logsearch-web/src/app/components/log-context/log-context.component.ts > 467de98 > > ambari-logsearch/ambari-logsearch-web/src/app/components/logs-container/logs-container.component.ts > 7345288 > > ambari-logsearch/ambari-logsearch-web/src/app/components/logs-list/logs-list.component.ts > c94b967 > > ambari-logsearch/ambari-logsearch-web/src/app/components/main-container/main-container.component.ts > 32fe1cf > > ambari-logsearch/ambari-logsearch-web/src/app/components/menu-button/menu-button.component.ts > 7e347e6 > > ambari-logsearch/ambari-logsearch-web/src/app/components/search-box/search-box.component.ts > e547a62 > > ambari-logsearch/ambari-logsearch-web/src/app/components/time-histogram/time-histogram.component.ts > c3ec388 > ambari-logsearch/ambari-logsearch-web/src/app/models/app-settings.model.ts > 11821a3 > ambari-logsearch/ambari-logsearch-web/src/app/models/app-state.model.ts > 267bf15 > > ambari-logsearch/ambari-logsearch-web/src/app/models/audit-log-field.model.ts > 96372a1 > ambari-logsearch/ambari-logsearch-web/src/app/models/audit-log.model.ts > 2b34cd6 > ambari-logsearch/ambari-logsearch-web/src/app/models/bar-graph.model.ts > 6c9a049 > ambari-logsearch/ambari-logsearch-web/src/app/models/common-entry.model.ts > dad82ab > ambari-logsearch/ambari-logsearch-web/src/app/models/count.model.ts 02fc41c > ambari-logsearch/ambari-logsearch-web/src/app/models/filter.model.ts > c7ff662 > ambari-logsearch/ambari-logsearch-web/src/app/models/graph.model.ts be31f19 > ambari-logsearch/ambari-logsearch-web/src/app/models/log-field.model.ts > 0e738ab > ambari-logsearch/ambari-logsearch-web/src/app/models/log.model.ts c598e41 > ambari-logsearch/ambari-logsearch-web/src/app/models/node.model.ts b01421e > > ambari-logsearch/ambari-logsearch-web/src/app/models/service-log-field.model.ts > 081eecf > ambari-logsearch/ambari-logsearch-web/src/app/models/service-log.model.ts > ee27343 > > ambari-logsearch/ambari-logsearch-web/src/app/models/solr-collection-state.model.ts > 0824dda > ambari-logsearch/ambari-logsearch-web/src/app/models/store.model.ts 518e7cd > ambari-logsearch/ambari-logsearch-web/src/app/models/user-config.model.ts > f52761c > > ambari-logsearch/ambari-logsearch-web/src/app/services/component-actions.service.ts > b3ff0b0 > > ambari-logsearch/ambari-logsearch-web/src/app/services/filtering.service.spec.ts > c4db041 > ambari-logsearch/ambari-logsearch-web/src/app/services/filtering.service.ts > 7fe6517 > > ambari-logsearch/ambari-logsearch-web/src/app/services/http-client.service.ts > 495f706 > > ambari-logsearch/ambari-logsearch-web/src/app/services/logs-container.service.ts > 14e9ad4 > > ambari-logsearch/ambari-logsearch-web/src/app/services/storage/app-settings.service.ts > 6de9988 > > ambari-logsearch/ambari-logsearch-web/src/app/services/storage/app-state.service.ts > d77d80f > > ambari-logsearch/ambari-logsearch-web/src/app/services/storage/audit-logs-fields.service.ts > bb8c661 > > ambari-logsearch/ambari-logsearch-web/src/app/services/storage/audit-logs.service.ts > bc33bd9 > > ambari-logsearch/ambari-logsearch-web/src/app/services/storage/clusters.service.ts > f21a8f9 > > ambari-logsearch/ambari-logsearch-web/src/app/services/storage/components.service.ts > 6b2a0ba > > ambari-logsearch/ambari-logsearch-web/src/app/services/storage/filters.service.ts > b850006 > > ambari-logsearch/ambari-logsearch-web/src/app/services/storage/graphs.service.ts > e541444 > > ambari-logsearch/ambari-logsearch-web/src/app/services/storage/hosts.service.ts > 0cb0a74 > > ambari-logsearch/ambari-logsearch-web/src/app/services/storage/service-logs-fields.service.ts > 0082cd6 > > ambari-logsearch/ambari-logsearch-web/src/app/services/storage/service-logs-histogram-data.service.ts > e680777 > > ambari-logsearch/ambari-logsearch-web/src/app/services/storage/service-logs-truncated.service.ts > f8fe0f7 > > ambari-logsearch/ambari-logsearch-web/src/app/services/storage/service-logs.service.ts > f0ff0d7 > > ambari-logsearch/ambari-logsearch-web/src/app/services/storage/user-configs.service.ts > 1596e78 > > > Diff: https://reviews.apache.org/r/62770/diff/1/ > > > Testing > ------- > > Executed 91 of 91 SUCCESS (2.491 secs / 2.474 secs) > > > Thanks, > > Andrii Babiichuk > >
