----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62778/#review187171 -----------------------------------------------------------
Ship it! Ship It! - Di Li On Oct. 4, 2017, 7:51 p.m., Tim Thorpe wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62778/ > ----------------------------------------------------------- > > (Updated Oct. 4, 2017, 7:51 p.m.) > > > Review request for Ambari, Di Li, Jonathan Hurley, and Jayush Luniya. > > > Bugs: AMBARI-22137 > https://issues.apache.org/jira/browse/AMBARI-22137 > > > Repository: ambari > > > Description > ------- > > Currently if you have extension version 0.1 linked to HDP 2.5, you can't link > extension version 0.2 to HDP 2.6. > > Attempting to make that link will fail with an exception stating that the > services included in extension version 0.2 are already in HDP 2.6 (inherited > from HDP 2.5 via the 0.1 version of the extension). > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementHelper.java > 2dd6f12 > > ambari-server/src/main/java/org/apache/ambari/server/stack/ExtensionHelper.java > 86e532a > ambari-server/src/main/java/org/apache/ambari/server/stack/StackModule.java > 6dc2b93 > > ambari-server/src/test/java/org/apache/ambari/server/stack/StackManagerExtensionTest.java > 20c8f40 > ambari-server/src/test/resources/extensions/EXT/0.2/metainfo.xml 0d37b3e > ambari-server/src/test/resources/extensions/EXT/0.3/metainfo.xml d827314 > > ambari-server/src/test/resources/stacks_with_extensions/HDP/0.4/metainfo.xml > PRE-CREATION > > ambari-server/src/test/resources/stacks_with_extensions/HDP/0.4/repos/repoinfo.xml > PRE-CREATION > > ambari-server/src/test/resources/stacks_with_extensions/HDP/0.4/services/HBASE/metainfo.xml > PRE-CREATION > > ambari-server/src/test/resources/stacks_with_extensions/HDP/0.4/services/HDFS/configuration/global.xml > PRE-CREATION > > ambari-server/src/test/resources/stacks_with_extensions/HDP/0.4/services/HDFS/configuration/hadoop-env.xml > PRE-CREATION > > ambari-server/src/test/resources/stacks_with_extensions/HDP/0.4/services/HDFS/configuration/hbase-site.xml > PRE-CREATION > > ambari-server/src/test/resources/stacks_with_extensions/HDP/0.4/services/HDFS/configuration/hdfs-log4j.xml > PRE-CREATION > > ambari-server/src/test/resources/stacks_with_extensions/HDP/0.4/services/HDFS/configuration/hdfs-site.xml > PRE-CREATION > > ambari-server/src/test/resources/stacks_with_extensions/HDP/0.4/services/HDFS/metainfo.xml > PRE-CREATION > > ambari-server/src/test/resources/stacks_with_extensions/HDP/0.4/services/HDFS/package/dummy-script.py > PRE-CREATION > > ambari-server/src/test/resources/stacks_with_extensions/HDP/0.4/services/HIVE/metainfo.xml > PRE-CREATION > > ambari-server/src/test/resources/stacks_with_extensions/HDP/0.4/services/MAPREDUCE/metainfo.xml > PRE-CREATION > > ambari-server/src/test/resources/stacks_with_extensions/HDP/0.4/services/ZOOKEEPER/metainfo.xml > PRE-CREATION > > > Diff: https://reviews.apache.org/r/62778/diff/1/ > > > Testing > ------- > > Manual testing with different extension and stack versions. > > mvn test -DskipPythonTests > -Dtest=StackManagerCommonServicesTest,StackManagerTest,StackManagerMiscTest,StackManagerExtensionTest > > > Thanks, > > Tim Thorpe > >
