----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62809/#review187335 -----------------------------------------------------------
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java Lines 2783 (patched) <https://reviews.apache.org/r/62809/#comment264257> can these variables calculated at params.py in the stack code instead of putting to the BlueprintConfigurationProcessor? (using jinja2 variables at configurations - you can get the proper hosts from command.json input). just because the ambari server java code could be independent from druid. im not too big fan of this class, we should get rid of it sooner or later but you can drop this issue if zou do not want to do it, it's just a reccomendation from me. - Oliver Szabo On Oct. 6, 2017, 3:35 p.m., Attila Doroszlai wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62809/ > ----------------------------------------------------------- > > (Updated Oct. 6, 2017, 3:35 p.m.) > > > Review request for Ambari, Nishant Bangarwa, Slim Bouguerra, and Swapan > Shridhar. > > > Bugs: AMBARI-22159 > https://issues.apache.org/jira/browse/AMBARI-22159 > > > Repository: ambari > > > Description > ------- > > Replace placeholders in `metastore_hostname`, > `druid.metadata.storage.connector.connectURI` and `druid.zk.service.host` > when creating cluster via blueprint. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java > 5a6e2cc0de7dc0c0f4499624e21c43bbc8d24b54 > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java > 68d6349db0207ab6df44b4b0a341c77ecabc46ea > > > Diff: https://reviews.apache.org/r/62809/diff/1/ > > > Testing > ------- > > Tested manually on local cluster. > > Unit tests pass: `Tests run: 4900, Failures: 0, Errors: 0, Skipped: 36` > > > Thanks, > > Attila Doroszlai > >
