> On Oct. 10, 2017, 3:23 a.m., Jayush Luniya wrote: > > ambari-server/src/main/java/org/apache/ambari/server/checks/AbstractCheckDescriptor.java > > Line 248 (original), 246 (patched) > > <https://reviews.apache.org/r/62856/diff/1/?file=1850073#file1850073line248> > > > > Should now be getName() instead of getServiceDisplayName() since we > > updated the semantics to (service_name, service_type) > > Nate Cole wrote: > What is this (service_name, service_type) you speak of? I would hope > we're keeping display (ZooKeeper) vs name (ZOOKEEPER). Are you saying > there's yet a 3rd service identifier? metainfo.xml already has a <type> > element, and that's for things like HCFS (Hadoop Compliant File System) - > what is that going to be called in this new world? > > Jayush Luniya wrote: > @Nate > service_name = ZK1, service_type = ZOOKEEPER for creating multiple > instances. The service display name remains ZooKeeper in the stack > definition. From UI perspective we have to see how we display this. Jaimin > suggested displaying this as "ZooKeeper" for the default instance and > "ZooKeeper (ZK1)" for 2nd instance and above. > > The service type in service definition will be termed service category.
@Jayush, That seems overly complicated. Why not use the service group name, as in: <display> (<service_group_name>): eg "ZooKeeper (Core)". You still end up with a trifecta of display, name, service_group_name. Changing name to NOT be the service name will be extremely confusing to those used to the v1 API. - Nate ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62856/#review187503 ----------------------------------------------------------- On Oct. 10, 2017, 12:58 a.m., Madhuvanthi Radhakrishnan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62856/ > ----------------------------------------------------------- > > (Updated Oct. 10, 2017, 12:58 a.m.) > > > Review request for Ambari, Jonathan Hurley, Jayush Luniya, and Swapan > Shridhar. > > > Bugs: AMBARI-22181 > https://issues.apache.org/jira/browse/AMBARI-22181 > > > Repository: ambari > > > Description > ------- > > Remove cluster-stackid dependency related to Configs > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/checks/AbstractCheckDescriptor.java > 6726d30e80 > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java > d0dd7e0d9c > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java > e9fa8db0d1 > > ambari-server/src/main/java/org/apache/ambari/server/controller/DeleteIdentityHandler.java > 29f8e2acbd > > ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/ConfigureAction.java > ec4d383dee > > ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java > bb7fcbed3d > ambari-server/src/main/java/org/apache/ambari/server/state/ConfigImpl.java > 44d76afcd8 > > ambari-server/src/main/java/org/apache/ambari/server/state/ConfigMergeHelper.java > cf556609a4 > > ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeHelper.java > 8f9d8e1b0b > > ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java > 6b32d4c75e > > > Diff: https://reviews.apache.org/r/62856/diff/1/ > > > Testing > ------- > > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 11:01 min > [INFO] Finished at: 2017-10-09T21:40:34-07:00 > [INFO] Final Memory: 359M/1174M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Madhuvanthi Radhakrishnan > >
