> On Oct. 10, 2017, 5:07 p.m., Nate Cole wrote: > > ambari-server/src/main/java/org/apache/ambari/server/state/repository/VersionDefinitionXml.java > > Lines 343-344 (patched) > > <https://reviews.apache.org/r/62871/diff/2/?file=1851385#file1851385line343> > > > > Ewww
Just following the Ambari Anti-Pattern :) ... OK, OK - let me make a POJO :) - Jonathan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62871/#review187589 ----------------------------------------------------------- On Oct. 10, 2017, 4:42 p.m., Jonathan Hurley wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62871/ > ----------------------------------------------------------- > > (Updated Oct. 10, 2017, 4:42 p.m.) > > > Review request for Ambari, Dmitro Lisnichenko, Nate Cole, and Robert Levas. > > > Bugs: AMBARI-22194 > https://issues.apache.org/jira/browse/AMBARI-22194 > > > Repository: ambari > > > Description > ------- > > Some stacks, such as HDP, do not support service-level upgrades for some > services since they have hard coded dependencies with other services which > might not be in the upgrade. > > For example, if YARN is configured to use Tez, then an upgrade of YARN or Tez > must also include Tez or YARN respectively. This is because the path is hard > coded inside of YARN to use its version and cannot be changed via any > external environment variable. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/checks/AbstractCheckDescriptor.java > d54e8a176a > > ambari-server/src/main/java/org/apache/ambari/server/checks/CheckDescription.java > 314ab83718 > > ambari-server/src/main/java/org/apache/ambari/server/checks/RequiredServicesInRepositoryCheck.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/checks/UpgradeCheck.java > 442bf0be12 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java > a2fb44199f > > ambari-server/src/main/java/org/apache/ambari/server/state/RepositoryType.java > 954f705e9f > > ambari-server/src/main/java/org/apache/ambari/server/state/repository/VersionDefinitionXml.java > c17f5e90f9 > > ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_packages.json > 2db0a74195 > > ambari-server/src/test/java/org/apache/ambari/server/checks/AbstractCheckDescriptorTest.java > 092bd0bd88 > > ambari-server/src/test/java/org/apache/ambari/server/checks/AutoStartDisabledCheckTest.java > 671648ab71 > > ambari-server/src/test/java/org/apache/ambari/server/checks/ClientRetryPropertyCheckTest.java > 206b4519c1 > > ambari-server/src/test/java/org/apache/ambari/server/checks/ComponentExistsInRepoCheckTest.java > ede1daacff > > ambari-server/src/test/java/org/apache/ambari/server/checks/ComponentsInstallationCheckTest.java > 4ae33f8bbf > > ambari-server/src/test/java/org/apache/ambari/server/checks/ConfigurationMergeCheckTest.java > df7bd1fb70 > > ambari-server/src/test/java/org/apache/ambari/server/checks/DruidHighAvailabilityCheckTest.java > e90931bc11 > > ambari-server/src/test/java/org/apache/ambari/server/checks/HiveMultipleMetastoreCheckTest.java > 7a1fca3161 > > ambari-server/src/test/java/org/apache/ambari/server/checks/HiveNotRollingWarningTest.java > 3b0c900991 > > ambari-server/src/test/java/org/apache/ambari/server/checks/HostsHeartbeatCheckTest.java > daf2e4cb76 > > ambari-server/src/test/java/org/apache/ambari/server/checks/HostsMasterMaintenanceCheckTest.java > 8afa1eaf89 > > ambari-server/src/test/java/org/apache/ambari/server/checks/HostsRepositoryVersionCheckTest.java > 5539618c28 > > ambari-server/src/test/java/org/apache/ambari/server/checks/InstallPackagesCheckTest.java > cdfbb0a790 > > ambari-server/src/test/java/org/apache/ambari/server/checks/KafkaKerberosCheckTest.java > 9a95c42327 > > ambari-server/src/test/java/org/apache/ambari/server/checks/MapReduce2JobHistoryStatePreservingCheckTest.java > fc322b3d91 > > ambari-server/src/test/java/org/apache/ambari/server/checks/RangerAuditDbCheckTest.java > ec91e483b3 > > ambari-server/src/test/java/org/apache/ambari/server/checks/RangerPasswordCheckTest.java > f9569c3820 > > ambari-server/src/test/java/org/apache/ambari/server/checks/RangerSSLConfigCheckTest.java > af016b01e0 > > ambari-server/src/test/java/org/apache/ambari/server/checks/RequiredServicesInRepositoryCheckTest.java > PRE-CREATION > > ambari-server/src/test/java/org/apache/ambari/server/checks/SecondaryNamenodeDeletedCheckTest.java > 5d0ca5f03d > > ambari-server/src/test/java/org/apache/ambari/server/checks/ServicesMaintenanceModeCheckTest.java > 65776519c8 > > ambari-server/src/test/java/org/apache/ambari/server/checks/ServicesMapReduceDistributedCacheCheckTest.java > a8569cc61f > > ambari-server/src/test/java/org/apache/ambari/server/checks/ServicesNamenodeHighAvailabilityCheckTest.java > c7e8fd63f1 > > ambari-server/src/test/java/org/apache/ambari/server/checks/ServicesNamenodeTruncateCheckTest.java > b252ec56b0 > > ambari-server/src/test/java/org/apache/ambari/server/checks/ServicesTezDistributedCacheCheckTest.java > 96eefc1cb8 > > ambari-server/src/test/java/org/apache/ambari/server/checks/ServicesUpCheckTest.java > 7cf0a38b87 > > ambari-server/src/test/java/org/apache/ambari/server/checks/ServicesYarnWorkPreservingCheckTest.java > 331223d0e6 > > ambari-server/src/test/java/org/apache/ambari/server/checks/StormShutdownWarningTest.java > 1441256719 > > ambari-server/src/test/java/org/apache/ambari/server/state/CheckHelperTest.java > 27b248f2a8 > > > Diff: https://reviews.apache.org/r/62871/diff/2/ > > > Testing > ------- > > Manual testing of an install / upgrade with and without services which > require dependencies. > > [INFO] Tests run: 4917, Failures: 0, Errors: 0, Skipped: 34 > [INFO] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 22:24 min > [INFO] Finished at: 2017-10-10T16:08:48-04:00 > [INFO] Final Memory: 61M/876M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Jonathan Hurley > >
