> On Жов. 11, 2017, 8:43 після полудня, Jayush Luniya wrote: > > ambari-server/src/main/java/org/apache/ambari/server/state/ServiceInfo.java > > Lines 1037 (patched) > > <https://reviews.apache.org/r/62895/diff/1/?file=1852428#file1852428line1037> > > > > Why not set themes itself instead of themeList?
As of now we are not reading themes/quicklinks from metainfo. But we have a code which set themesMap/quicklinksMap with related data. This data is the result of merge for all stack versions. We have inheritence for many components in metainfo like (osspecific packages, quick links, themes and other). The same behaviour you can see for OsSpecific in ServiceInfo. So it will be more correctly to use merged data. - Vitalyi ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62895/#review187697 ----------------------------------------------------------- On Жов. 11, 2017, 4:17 після полудня, Vitalyi Brodetskyi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62895/ > ----------------------------------------------------------- > > (Updated Жов. 11, 2017, 4:17 після полудня) > > > Review request for Ambari, Dmitro Lisnichenko, Jayush Luniya, and Madhuvanthi > Radhakrishnan. > > > Bugs: AMBARI-22209 > https://issues.apache.org/jira/browse/AMBARI-22209 > > > Repository: ambari > > > Description > ------- > > Fix quick links in mpacks. > > > Diffs > ----- > > ambari-server/src/main/java/org/apache/ambari/server/state/ServiceInfo.java > 1cad4df > > > Diff: https://reviews.apache.org/r/62895/diff/1/ > > > Testing > ------- > > will check tests after approve > > > Thanks, > > Vitalyi Brodetskyi > >
