----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62924/#review187764 -----------------------------------------------------------
Ship it! Ship It! - Pallav Kulshreshtha On Oct. 12, 2017, 6:37 a.m., Prabhjyot Singh wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62924/ > ----------------------------------------------------------- > > (Updated Oct. 12, 2017, 6:37 a.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Jaimin Jetly, Jayush Luniya, > Rohit Choudhary, Sumit Mohanty, and venkat sairam. > > > Bugs: AMBARI-22212 > https://issues.apache.org/jira/browse/AMBARI-22212 > > > Repository: ambari > > > Description > ------- > > Right now Ambari assumes if "FileSystemNotebookRepo" is set for > "zeppelin.notebook.storage" then both notebook and conf are in HDFS. > > But the right logic will be if ("zeppelin.config.fs.dir" is empty or > "zeppelin.config.fs.dir" start with "file://") it is stored in FS else HDFS > and also check for > "/etc/zeppelin/conf/external-dependency-conf/hdfs-site.xml" if exists. > > > Diffs > ----- > > > ambari-server/src/main/resources/common-services/ZEPPELIN/0.7.0/package/scripts/master.py > 09944bd277 > > ambari-server/src/main/resources/common-services/ZEPPELIN/0.7.0/package/scripts/params.py > 3242f2621a > ambari-server/src/test/python/stacks/2.6/ZEPPELIN/test_zeppelin_070.py > 3adb94ce1a > > > Diff: https://reviews.apache.org/r/62924/diff/1/ > > > Testing > ------- > > Manually > > > Thanks, > > Prabhjyot Singh > >
