----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62945/#review187845 -----------------------------------------------------------
Ship it! Ship It! - Jonathan Hurley On Oct. 12, 2017, 2:57 p.m., Robert Levas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62945/ > ----------------------------------------------------------- > > (Updated Oct. 12, 2017, 2:57 p.m.) > > > Review request for Ambari, Attila Magyar, Balázs Bence Sári, Eugene > Chekanskiy, Jonathan Hurley, Laszlo Puskas, Nate Cole, and Sebastian Toader. > > > Bugs: AMBARI-22224 > https://issues.apache.org/jira/browse/AMBARI-22224 > > > Repository: ambari > > > Description > ------- > > The host and hostname built-in variables are not populated when performing > Kerberos-related operations. These variables may be used like > > ``` > service-${host} > ``` > > If the current host being processed is host1.example.com, the value should be > converted to > > ``` > service-host1.example.com > ``` > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelperImpl.java > f8fe31a33d > > ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/AbstractPrepareKerberosServerAction.java > 3db844ad2a > > ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/PreconfigureKerberosAction.java > d18f333e6b > > ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/AbstractPrepareKerberosServerActionTest.java > 8ff5ad27c3 > > > Diff: https://reviews.apache.org/r/62945/diff/1/ > > > Testing > ------- > > Manually tested > > # Local test results: > ``` > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 24:35 min > [INFO] Finished at: 2017-10-12T13:44:20-04:00 > [INFO] Final Memory: 72M/877M > [INFO] > ------------------------------------------------------------------------ > ``` > > > Thanks, > > Robert Levas > >
