----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62948/#review187865 -----------------------------------------------------------
Ship it! Ship It! - Robert Levas On Oct. 12, 2017, 4:33 p.m., Sebastian Toader wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62948/ > ----------------------------------------------------------- > > (Updated Oct. 12, 2017, 4:33 p.m.) > > > Review request for Ambari, Balázs Bence Sári, Nate Cole, Robert Levas, and > Sandor Magyari. > > > Bugs: AMBARI-22225 > https://issues.apache.org/jira/browse/AMBARI-22225 > > > Repository: ambari > > > Description > ------- > > Cluster created with Blueprint using host predicates rejects hosts even > though their host_name matches the host predicate. > > `{ "name": "workernode", "host_count": "2", "host_predicate": > "Hosts/host_name.matches(agent-*)" }` > > ``` > 11 Oct 2017 17:03:11,296 INFO [qtp-ambari-agent-56] TopologyManager:698 - > TopologyManager: Queueing available host agent-1 > 11 Oct 2017 17:04:56,783 INFO [ambari-client-thread-45] TopologyManager:876 > - TopologyManager.processRequest: offering host name = agent-1 to > LogicalRequest ID = 1 > 11 Oct 2017 17:04:56,783 INFO [ambari-client-thread-45] LogicalRequest:101 - > LogicalRequest.offer: attempting to match a request to a request for a > reserved host to hostname = agent-1 > 11 Oct 2017 17:04:56,784 INFO [ambari-client-thread-45] LogicalRequest:125 - > LogicalRequest.offer: attempting to match a request to a request for a > non-reserved host to hostname = agent-1 > 11 Oct 2017 17:04:56,791 INFO [ambari-client-thread-45] LogicalRequest:138 - > LogicalRequest.offer: host request returned DECLINED_PREDICATE for hostname = > agent-1 > 11 Oct 2017 17:04:56,792 INFO [ambari-client-thread-45] LogicalRequest:125 - > LogicalRequest.offer: attempting to match a request to a request for a > non-reserved host to hostname = agent-1 > 11 Oct 2017 17:04:56,793 INFO [ambari-client-thread-45] LogicalRequest:138 - > LogicalRequest.offer: host request returned DECLINED_PREDICATE for hostname = > agent-1 > 11 Oct 2017 17:04:56,794 INFO [ambari-client-thread-45] TopologyManager:896 > - TopologyManager.processRequest: host name = agent-1 was DECLINED_PREDICATE > by LogicalRequest ID = 1 > ``` > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/topology/HostRequest.java > 784c923 > > > Diff: https://reviews.apache.org/r/62948/diff/1/ > > > Testing > ------- > > Manual testing with Blueprint with host predicates. > > Unit tests: > [INFO] > ------------------------------------------------------------------------ > [INFO] Reactor Summary: > [INFO] > [INFO] Ambari Main ........................................ SUCCESS [ 35.702 > s] > [INFO] Apache Ambari Project POM .......................... SUCCESS [ 0.008 > s] > [INFO] Ambari Views ....................................... SUCCESS [ 4.404 > s] > [INFO] utility ............................................ SUCCESS [ 1.716 > s] > [INFO] ambari-metrics ..................................... SUCCESS [ 1.187 > s] > [INFO] Ambari Metrics Common .............................. SUCCESS [ 7.373 > s] > [INFO] Ambari Server ...................................... SUCCESS [24:04 > min] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Sebastian Toader > >
