> On Oct. 14, 2017, 12:18 a.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/AtlasProxyUserConfigCalculation.java > > Lines 38 (patched) > > <https://reviews.apache.org/r/62985/diff/1/?file=1855434#file1855434line38> > > > > Hard coded? This can't be configured by administrators?
I agree, Administrators can configure the value. Here 'knox' is a default value required to be provided if Knox is externally configured to use Atlas via proxy, eventually if a custom-user is used for the external knox, then this value will need to be manually configured. Here default value is referred from Atlas side implementation where 'knox' is the default value.Reference here -> https://github.com/apache/atlas/blob/master/webapp/src/main/java/org/apache/atlas/web/filters/AtlasAuthenticationFilter.java#L88 - Vishal ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62985/#review188051 ----------------------------------------------------------- On Oct. 13, 2017, 8:21 p.m., Vishal Suvagia wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62985/ > ----------------------------------------------------------- > > (Updated Oct. 13, 2017, 8:21 p.m.) > > > Review request for Ambari, Gautam Borad, Jonathan Hurley, Madhan Neethiraj, > Mugdha Varadkar, Nate Cole, and Nixon Rodrigues. > > > Bugs: AMBARI-22232 > https://issues.apache.org/jira/browse/AMBARI-22232 > > > Repository: ambari > > > Description > ------- > > When Atlas is enabled via proxy needs to know the proxy-users to authorize > them while accessing the Atlas service via proxy support using property > atlas.proxyusers with default value knox. Additional details on ATLAS-2166. > > PS: Attached patch is applicable for trunk branch, patch for branch-2.6 is > attached on Apache JIRA. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/AtlasProxyUserConfigCalculation.java > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.6.xml > 1af3b18 > ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.6.xml > 0a01a04 > > ambari-server/src/main/resources/stacks/HDP/2.6/services/ATLAS/configuration/application-properties.xml > c271dc3 > ambari-server/src/main/resources/stacks/HDP/2.6/services/stack_advisor.py > 94f28db > > ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/nonrolling-upgrade-2.6.xml > ebb81d9 > ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/upgrade-2.6.xml > ae5972e > > ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/AtlasProxyUserConfigCalculationTest.java > PRE-CREATION > ambari-server/src/test/python/stacks/2.6/common/test_stack_advisor.py > ade08c1 > > > Diff: https://reviews.apache.org/r/62985/diff/2/ > > > Testing > ------- > > Verified with fresh-install and EU on CentOS 6. > > > Thanks, > > Vishal Suvagia > >
