-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62982/
-----------------------------------------------------------
Review request for Ambari, Jonathan Hurley, Nate Cole, and Sebastian Toader.
Bugs: AMBARI-22236
https://issues.apache.org/jira/browse/AMBARI-22236
Repository: ambari
Description
-------
Many of the existing JMX alerts use expressions like this
"jmx": {
"property_list": [
"Hadoop:service=NameNode,name=FSNamesystemState/CapacityUsed",
"Hadoop:service=NameNode,name=FSNamesystemState/CapacityRemaining"
],
"value": "{0}/({0} + {1}) * 100.0"
}
JMXServerSide alert should be able to evaluate these expressions in a secure
and safe way.
Supported operators: +,-,*,/,(,)
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/alerts/JmxServerSideAlert.java
a4b86f8
ambari-server/src/main/java/org/apache/ambari/server/state/alert/AlertDefinition.java
665430d
ambari-server/src/main/java/org/apache/ambari/server/state/alert/MetricSource.java
d7283fe
ambari-server/src/main/java/org/apache/ambari/server/state/alert/Reporting.java
51d074e
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AlertDefinitionResourceProviderTest.java
3ef2c48
ambari-server/src/test/java/org/apache/ambari/server/state/alert/JmxInfoTest.java
PRE-CREATION
Diff: https://reviews.apache.org/r/62982/diff/1/
Testing
-------
tested with an JMX alert with value="{0}/({0} + {1}) * 100.0"
existing tests: pending
Thanks,
Attila Magyar
