----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62996/#review188125 -----------------------------------------------------------
Ship it! Ship It! - Jonathan Hurley On Oct. 15, 2017, 9:53 p.m., Nate Cole wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62996/ > ----------------------------------------------------------- > > (Updated Oct. 15, 2017, 9:53 p.m.) > > > Review request for Ambari, Dmytro Grinenko, Dmitro Lisnichenko, and Jonathan > Hurley. > > > Bugs: AMBARI-22240 > https://issues.apache.org/jira/browse/AMBARI-22240 > > > Repository: ambari > > > Description > ------- > > Turns out when we did the import for PU, we neglected to bring over the > per-service config changes that are required to support it. This didn't show > during all our development because we were only checking on the same stack. > > This jira brings in those changes such that we are correctly creating and > reverting configs when crossing stack versions. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementController.java > 91bfe09deb > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java > 18659d44a1 > > ambari-server/src/main/java/org/apache/ambari/server/state/ConfigFactory.java > d6cd99786c > > ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java > 987ff3818d > ambari-server/src/main/java/org/apache/ambari/server/state/ConfigImpl.java > 0a861d80c9 > > ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeHelper.java > 77e2d47d09 > > ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java > 6bde42c10b > > ambari-server/src/main/java/org/apache/ambari/server/state/configgroup/ConfigGroupImpl.java > 1a8b5b61f2 > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/AbstractUpgradeCatalog.java > d7cd087001 > > ambari-server/src/test/java/org/apache/ambari/server/actionmanager/ExecutionCommandWrapperTest.java > 87721e4ccd > > ambari-server/src/test/java/org/apache/ambari/server/agent/HeartbeatTestHelper.java > 76f4bb30d9 > > ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatMonitor.java > 088ec8ddd2 > > ambari-server/src/test/java/org/apache/ambari/server/upgrade/AbstractUpgradeCatalogTest.java > 96ccc57f39 > > ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog250Test.java > 2590d1c995 > > ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog252Test.java > e6dbb7c0cf > > ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog260Test.java > 23962b7d79 > > > Diff: https://reviews.apache.org/r/62996/diff/2/ > > > Testing > ------- > > Manual IN PROGRESS: > RU Full through Finalize (DONE) > RU Full but Downgrade (DONE) > EU Full through Finalize (DONE) > EU Full but Downgrade (DONE) > > EU Patch but Downgrade (DONE) > EU Patch then Finalize (DONE) > EU Patch then Finalize then Revert (DONE) > > PENDING Unit tests: > Verify no tests are broken with this change: > > > Thanks, > > Nate Cole > >
