----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63051/#review188496 -----------------------------------------------------------
ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceGroupRequest.java Lines 29 (patched) <https://reviews.apache.org/r/63051/#comment265484> It will be nice to replace map with POJO: Something like Set<ServiceGroupKey> will make whole patch easier to read and remove hardcoded key names. - Myroslav Papirkovskyy On Жов. 17, 2017, 11:38 після полудня, Vitalyi Brodetskyi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63051/ > ----------------------------------------------------------- > > (Updated Жов. 17, 2017, 11:38 після полудня) > > > Review request for Ambari, Jayush Luniya, Myroslav Papirkovskyy, and Swapan > Shridhar. > > > Bugs: AMBARI-22249 > https://issues.apache.org/jira/browse/AMBARI-22249 > > > Repository: ambari > > > Description > ------- > > Add table servicegroupdependencies > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceGroupRequest.java > 53c3d1e > > ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceGroupResponse.java > 147650c > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceGroupResourceProvider.java > 2e935af > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ServiceGroupEntity.java > 7f8facb > ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java > 8fd878e > > ambari-server/src/main/java/org/apache/ambari/server/state/ServiceGroup.java > 9850462 > > ambari-server/src/main/java/org/apache/ambari/server/state/ServiceGroupFactory.java > 7146bdf > > ambari-server/src/main/java/org/apache/ambari/server/state/ServiceGroupImpl.java > 735a946 > > ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java > fcc07b6 > > ambari-server/src/main/java/org/apache/ambari/server/topology/AmbariContext.java > 0434728 > ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql b8c0a42 > ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql c56e486 > ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 8917d48 > ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql f48bcd6 > ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql e7c5c72 > ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql f87af4c > > > Diff: https://reviews.apache.org/r/63051/diff/2/ > > > Testing > ------- > > Will fix tests after patch approve > > > Thanks, > > Vitalyi Brodetskyi > >
