-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63118/
-----------------------------------------------------------
Review request for Ambari, Miklos Gergely and Robert Nettleton.
Bugs: AMBARI-22266
https://issues.apache.org/jira/browse/AMBARI-22266
Repository: ambari
Description
-------
If logsearch running behind a proxy and the address is not on root, UI cannot
be accessed/handled properly.
(like: localhost:61888 can be accessed through localhost:8080/logsearch/)
Regarding to that issue, there are some backend changes that required:
- form login filter needs to be removed, as we have are custom login entripoint
already (that form login filter is basically the same, so we had 2 different
filter on each other, which did the same)
- add useForward (configurable) to our login entrypoint, to make it possible to
send redirects through proxies properly
- on logout: add useReferer, which can be used if logsearch is behind a proxy,
it can use the referer location instead of the root one.
Diffs
-----
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/conf/AuthPropsConfig.java
54cc10c
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/conf/SecurityConfig.java
2f9cba4
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/web/authenticate/LogsearchLogoutSuccessHandler.java
c20e383
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/web/filters/LogsearchAuthenticationEntryPoint.java
1831697
Diff: https://reviews.apache.org/r/63118/diff/1/
Testing
-------
done, works with both proxies and without proxies (for proxies there should be
some ui changes as well)
Thanks,
Oliver Szabo
