----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63196/#review188895 -----------------------------------------------------------
Ship it! Ship It! - Oliver Szabo On Oct. 21, 2017, 12:58 a.m., Miklos Gergely wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63196/ > ----------------------------------------------------------- > > (Updated Oct. 21, 2017, 12:58 a.m.) > > > Review request for Ambari, Krisztian Kasa, Oliver Szabo, and Robert Nettleton. > > > Bugs: AMBARI-22281 > https://issues.apache.org/jira/browse/AMBARI-22281 > > > Repository: ambari > > > Description > ------- > > Due to a bug Log Feeders throw NPEs while searching for logs of services > which are not present on the node, but present on the cluster. > > The problem was caused by the fact that File.listFiles(FileFilter) returns > null if the file it's called on is not an existing directory, and > Arrays.sort() throws an NPE if it's argument is null. > > > Diffs > ----- > > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/InputFile.java > e24a7aa > > > Diff: https://reviews.apache.org/r/63196/diff/1/ > > > Testing > ------- > > Tested on local cluster > > > Thanks, > > Miklos Gergely > >
