----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63222/#review188970 -----------------------------------------------------------
Ship it! Ship It! - Jonathan Hurley On Oct. 23, 2017, 2:04 p.m., Nate Cole wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63222/ > ----------------------------------------------------------- > > (Updated Oct. 23, 2017, 2:04 p.m.) > > > Review request for Ambari and Jonathan Hurley. > > > Bugs: AMBARI-22292 > https://issues.apache.org/jira/browse/AMBARI-22292 > > > Repository: ambari > > > Description > ------- > > Version comparison was not taking into account the build number. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java > a20658304f > > ambari-server/src/main/java/org/apache/ambari/server/state/repository/VersionDefinitionXml.java > 7944de8e8c > > ambari-server/src/main/java/org/apache/ambari/server/utils/VersionUtils.java > d3d859258d > > ambari-server/src/test/java/org/apache/ambari/server/state/repository/VersionDefinitionTest.java > 8433518691 > > ambari-server/src/test/java/org/apache/ambari/server/utils/TestVersionUtils.java > 5141dc0fbf > > > Diff: https://reviews.apache.org/r/63222/diff/1/ > > > Testing > ------- > > Manual. Unit tests pending. > > > Thanks, > > Nate Cole > >
