----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63297/#review189202 -----------------------------------------------------------
Ship it! Ship It! - Nate Cole On Oct. 25, 2017, 10:04 a.m., Attila Magyar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63297/ > ----------------------------------------------------------- > > (Updated Oct. 25, 2017, 10:04 a.m.) > > > Review request for Ambari, Jonathan Hurley, Nate Cole, and Sebastian Toader. > > > Bugs: AMBARI-22115 > https://issues.apache.org/jira/browse/AMBARI-22115 > > > Repository: ambari > > > Description > ------- > > - JXMServerSideAlert should be able to process jmx properties like: > java.lang:type=Memory/HeapMemoryUsage[max] > - added 3 alerts into the mpack's alerts.json > - fixed ams non-host metrics by adding timelineAppid=NAMENODE > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/controller/jmx/JMXMetricHolder.java > f6ae54f > > ambari-server/src/main/java/org/apache/ambari/server/state/alert/Reporting.java > a7e11e1 > > ambari-server/src/test/java/org/apache/ambari/server/controller/jmx/JMXMetricHolderTest.java > 61d5bae > > contrib/management-packs/isilon-onefs-mpack/src/main/resources/addon-services/ONEFS/1.0.0/alerts.json > 5718721 > > contrib/management-packs/isilon-onefs-mpack/src/main/resources/addon-services/ONEFS/1.0.0/configuration/hadoop-env.xml > bb671cc > > contrib/management-packs/isilon-onefs-mpack/src/main/resources/addon-services/ONEFS/1.0.0/metainfo.xml > f20bcf8 > > contrib/management-packs/isilon-onefs-mpack/src/main/resources/addon-services/ONEFS/1.0.0/metrics.json > cd705eb > > contrib/management-packs/isilon-onefs-mpack/src/main/resources/addon-services/ONEFS/1.0.0/package/scripts/params_linux.py > 72e0ae9 > > contrib/management-packs/isilon-onefs-mpack/src/main/resources/addon-services/ONEFS/1.0.0/widgets.json > 23da1d6 > > > Diff: https://reviews.apache.org/r/63297/diff/1/ > > > Testing > ------- > > tested manually with 3 different jmx alerts. > > existing tests: passed > > > Thanks, > > Attila Magyar > >
