-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63330/
-----------------------------------------------------------

Review request for Ambari, Balázs Bence Sári, Nate Cole, and Sebastian Toader.


Bugs: AMBARI-22319
    https://issues.apache.org/jira/browse/AMBARI-22319


Repository: ambari


Description
-------

Both HDFS and OneFS defines core-site and hdfs-site. When creating a desired 
config the config type is passed as an input parameter without the service 
name. Therefore the backend is responsible for linking the config to the 
correct service. If there are multiple services with the same config type, the 
current implementation will fail to choose the correct service.

This is a partial and maybe temporary fix which is needed to make progress. The 
linear search that gets the service name by config type is replaced with one 
that only searches through the installed services (onefs and hdfs is not 
installed at the same time).


Diffs
-----

  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
 1b1f524 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/Stack.java
 f8feef2 
  ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java 
eade914 
  
ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java
 9c0b0ca 
  
ambari-server/src/main/java/org/apache/ambari/server/topology/AmbariContext.java
 eb39562 
  
ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterTest.java
 4b09c6d 
  
ambari-server/src/test/java/org/apache/ambari/server/topology/AmbariContextTest.java
 0deeae9 


Diff: https://reviews.apache.org/r/63330/diff/1/


Testing
-------

manually: used the isilon mpack to install onefs
existing tests: passed


Thanks,

Attila Magyar

Reply via email to