-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63354/
-----------------------------------------------------------
(Updated Oct. 27, 2017, 10:24 a.m.)
Review request for Ambari and Robert Levas.
Changes
-------
Added new RR for the feature to simplify the review
Bugs: AMBARI-21307
https://issues.apache.org/jira/browse/AMBARI-21307
Repository: ambari
Description (updated)
-------
(duplcate of: https://reviews.apache.org/r/60466/)
* New rest resource for supporting the configuration from the UI
* Backend logic for user and group related configuration attribute detection
Diffs
-----
ambari-funtest/pom.xml bb2068d
ambari-project/pom.xml 00ba1bc
ambari-server/pom.xml e250da7
ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java
d0d115d
ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariConfigurationRequestSwagger.java
PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariConfigurationResponseSwagger.java
PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariConfigurationService.java
PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/api/services/ldap/AmbariConfiguration.java
PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/api/services/ldap/LdapConfigOperation.java
PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/api/services/ldap/LdapConfigurationRequest.java
PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/api/services/ldap/LdapConfigurationService.java
PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/api/services/ldap/LdapRequestInfo.java
PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/StackAdvisorRequest.java
3a2b488
ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/commands/StackAdvisorCommand.java
356754d
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java
8988be0
ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java
dc97871
ambari-server/src/main/java/org/apache/ambari/server/controller/ResourceProviderFactory.java
a198775
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java
a98ad46
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractProviderModule.java
1cd2d10
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AmbariConfigurationResourceProvider.java
PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/DefaultProviderModule.java
43779a3
ambari-server/src/main/java/org/apache/ambari/server/controller/spi/Resource.java
362b4e6
ambari-server/src/main/java/org/apache/ambari/server/events/AmbariEvent.java
9a5ee79
ambari-server/src/main/java/org/apache/ambari/server/events/AmbariLdapConfigChangedEvent.java
PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/ldap/LdapModule.java
PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/ldap/domain/AmbariLdapConfigKeys.java
PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/ldap/domain/AmbariLdapConfiguration.java
PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/ldap/domain/AmbariLdapConfigurationFactory.java
PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/ldap/service/AmbariLdapConfigurationProvider.java
PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/ldap/service/AmbariLdapException.java
PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/ldap/service/AmbariLdapFacade.java
PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/ldap/service/AttributeDetector.java
PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/ldap/service/LdapAttributeDetectionService.java
PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/ldap/service/LdapConfigurationService.java
PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/ldap/service/LdapConnectionConfigService.java
PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/ldap/service/LdapFacade.java
PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/ldap/service/ads/DefaultLdapAttributeDetectionService.java
PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/ldap/service/ads/DefaultLdapConfigurationService.java
PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/ldap/service/ads/DefaultLdapConnectionConfigService.java
PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/ldap/service/ads/LdapConnectionTemplateFactory.java
PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/ldap/service/ads/detectors/AttributeDetectorFactory.java
PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/ldap/service/ads/detectors/ChainedAttributeDetector.java
PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/ldap/service/ads/detectors/GroupMemberAttrDetector.java
PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/ldap/service/ads/detectors/GroupNameAttrDetector.java
PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/ldap/service/ads/detectors/GroupObjectClassDetector.java
PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/ldap/service/ads/detectors/OccurrenceAndWeightBasedDetector.java
PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/ldap/service/ads/detectors/UserGroupMemberAttrDetector.java
PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/ldap/service/ads/detectors/UserNameAttrDetector.java
PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/ldap/service/ads/detectors/UserObjectClassDetector.java
PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/AmbariConfigurationDAO.java
PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/DaoUtils.java
cd3faf0
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/AmbariConfigurationEntity.java
PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ConfigurationBaseEntity.java
PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/security/authorization/RoleAuthorization.java
cd35c2c
ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql 015ec0a
ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql eb9ca96
ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql dac3f28
ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql c321a38
ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 8740ed7
ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 415589d
ambari-server/src/main/resources/META-INF/persistence.xml e4045ef
ambari-server/src/test/java/org/apache/ambari/server/api/services/stackadvisor/commands/StackAdvisorCommandTest.java
eaa4716
ambari-server/src/test/java/org/apache/ambari/server/checks/UpgradeCheckOrderTest.java
aa975e2
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AmbariConfigurationResourceProviderTest.java
PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StackAdvisorResourceProviderTest.java
ab60948
ambari-server/src/test/java/org/apache/ambari/server/ldap/LdapModuleFunctionalTest.java
PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/ldap/domain/TestAmbariLdapConfigurationFactory.java
PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/ldap/service/AmbariLdapFacadeTest.java
PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/ldap/service/ads/DefaultLdapAttributeDetectionServiceTest.java
PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/ldap/service/ads/DefaultLdapConfigurationServiceTest.java
PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/ldap/service/ads/detectors/GroupMemberAttrDetectorTest.java
PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/notifications/DispatchFactoryTest.java
382799c
ambari-server/src/test/java/org/apache/ambari/server/orm/InMemoryDefaultTestModule.java
434a2a1
ambari-server/src/test/java/org/apache/ambari/server/orm/JdbcPropertyTest.java
427cede
ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AmbariLdapAuthenticationProviderForDNWithSpaceTest.java
442414f
ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AmbariLdapAuthenticationProviderTest.java
4941bc7
ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AmbariLocalUserProviderTest.java
2362823
ambari-server/src/test/java/org/apache/ambari/server/security/authorization/LdapServerPropertiesTest.java
5747408
Diff: https://reviews.apache.org/r/63354/diff/1/
Testing
-------
* unit tests written
* manually: postman collection attached to the jira with sample calls
Thanks,
Laszlo Puskas
