----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63051/#review189812 -----------------------------------------------------------
ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql Lines 162 (patched) <https://reviews.apache.org/r/63051/#comment267021> Add an id column to the table as primary key (i.e. dependency_id) ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql Lines 167 (patched) <https://reviews.apache.org/r/63051/#comment267022> Make this as unique constraint rather than primary key and add "id" as primary key. See alerts tables for example CREATE TABLE alert_group ( group_id BIGINT NOT NULL, cluster_id BIGINT NOT NULL, group_name VARCHAR(255) NOT NULL, is_default SMALLINT NOT NULL DEFAULT 0, service_name VARCHAR(255), CONSTRAINT PK_alert_group PRIMARY KEY (group_id), CONSTRAINT uni_alert_group_name UNIQUE(cluster_id,group_name) ); - Jayush Luniya On Oct. 25, 2017, 11:18 p.m., Vitalyi Brodetskyi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63051/ > ----------------------------------------------------------- > > (Updated Oct. 25, 2017, 11:18 p.m.) > > > Review request for Ambari, Jayush Luniya, Myroslav Papirkovskyy, and Swapan > Shridhar. > > > Bugs: AMBARI-22249 > https://issues.apache.org/jira/browse/AMBARI-22249 > > > Repository: ambari > > > Description > ------- > > Add table servicegroupdependencies > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java > 737b9b4 > > ambari-server/src/main/java/org/apache/ambari/server/api/resources/ServiceGroupDependencyResourceDefinition.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/api/resources/ServiceGroupResourceDefinition.java > 13bdd7b > > ambari-server/src/main/java/org/apache/ambari/server/api/services/ServiceGroupKey.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/api/services/ServiceGroupService.java > 1e2eaf4 > > ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java > 3117186 > > ambari-server/src/main/java/org/apache/ambari/server/controller/ResourceProviderFactory.java > f75a7d5 > > ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceGroupDependencyRequest.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceGroupDependencyResponse.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java > b8c1674 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/DefaultProviderModule.java > cfab185 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceGroupDependencyResourceProvider.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceGroupResourceProvider.java > 2e935af > > ambari-server/src/main/java/org/apache/ambari/server/controller/spi/Resource.java > 6a76fff > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ServiceGroupEntity.java > 7f8facb > ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java > 8fd878e > > ambari-server/src/main/java/org/apache/ambari/server/state/ServiceGroup.java > 9850462 > > ambari-server/src/main/java/org/apache/ambari/server/state/ServiceGroupFactory.java > 7146bdf > > ambari-server/src/main/java/org/apache/ambari/server/state/ServiceGroupImpl.java > 735a946 > > ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java > 1e4d81f > > ambari-server/src/main/java/org/apache/ambari/server/topology/AmbariContext.java > 0434728 > ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql b8c0a42 > ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql c56e486 > ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 8917d48 > ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql f48bcd6 > ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql e7c5c72 > ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql f87af4c > > > Diff: https://reviews.apache.org/r/63051/diff/8/ > > > Testing > ------- > > Will fix tests after patch approve > > > Thanks, > > Vitalyi Brodetskyi > >
