-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63516/
-----------------------------------------------------------
Review request for Ambari, Jonathan Hurley and Nate Cole.
Bugs: AMBARI-22353
https://issues.apache.org/jira/browse/AMBARI-22353
Repository: ambari
Description
-------
Legacy/ancient ResourceProviders use the {{properties.json}} file to govern
which properties can be used with the provider. This seems like excessive
decoupling without any benefit and usually leads to runtime errors when new or
removed properties are forgotten.
This file should be removed and the providers should be registering the known
properties on their own.
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/controller/ResourceProviderFactory.java
711ae10f7e
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java
1dc0841d19
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractDRResourceProvider.java
953a2a7c77
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ActionResourceProvider.java
4e618e7ff6
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintResourceProvider.java
73d24908ea
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProvider.java
a2a49d7cb5
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ConfigGroupResourceProvider.java
737bfa4d46
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/DefaultProviderModule.java
c3758b3f5e
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ExtensionLinkResourceProvider.java
db904bf714
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ExtensionResourceProvider.java
53e44e1888
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ExtensionVersionResourceProvider.java
4aa357c0e3
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/FeedResourceProvider.java
f9d75fd353
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/GroupResourceProvider.java
f051651e12
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostComponentProcessResourceProvider.java
2a25bc4d02
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostComponentResourceProvider.java
6708560969
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostResourceProvider.java
5373ffe31c
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/InstanceResourceProvider.java
d3a695ba08
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/JobResourceProvider.java
e70c3674b4
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/KerberosDescriptorResourceProvider.java
93013415b4
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/LoggingResourceProvider.java
d6afe7b22b
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/MemberResourceProvider.java
d9d56eee8c
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RecommendationResourceProvider.java
70ed3dc09f
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RequestResourceProvider.java
81f283c55b
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RequestScheduleResourceProvider.java
4e25369a6e
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RootServiceComponentResourceProvider.java
3925aebdae
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RootServiceHostComponentResourceProvider.java
c37bb2efe7
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RootServiceResourceProvider.java
b24a94aee0
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackConfigurationDependencyResourceProvider.java
366b3ef052
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackConfigurationResourceProvider.java
6f5b0f8c02
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackDependencyResourceProvider.java
8b69c6a312
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackLevelConfigurationResourceProvider.java
819507bffd
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackResourceProvider.java
ead4f6df2b
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackServiceComponentResourceProvider.java
b9661bb409
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackServiceResourceProvider.java
8727741d37
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackVersionResourceProvider.java
094c75bbb8
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/TargetClusterResourceProvider.java
d0c37f5a9e
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/TaskAttemptResourceProvider.java
3af7bb15e5
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/TaskResourceProvider.java
0b4fcd9633
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UserResourceProvider.java
c5c36e9942
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ValidationResourceProvider.java
b78c64af53
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/WorkflowResourceProvider.java
13cb8a4768
ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/PropertyHelper.java
893978047c
ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/AmbariMetricSinkImpl.java
5c5801d451
ambari-server/src/main/resources/key_properties.json 5d76062d87
ambari-server/src/main/resources/properties.json 1d12f83b3f
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProviderTest.java
a127de6539
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AbstractDRResourceProviderTest.java
38e6d366a1
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AbstractResourceProviderTest.java
7165e48d70
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ActionResourceProviderTest.java
ef56f9d3e7
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ActiveWidgetLayoutResourceProviderTest.java
5221ecf16b
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintResourceProviderTest.java
f53441182b
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProviderTest.java
833be5d117
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterKerberosDescriptorResourceProviderTest.java
ac2847590d
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterResourceProviderTest.java
4a808931ac
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProviderTest.java
984010650c
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ConfigGroupResourceProviderTest.java
78f79ead9c
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ConfigurationResourceProviderTest.java
785ea2388b
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/CredentialResourceProviderTest.java
89ed022da0
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ExtensionResourceProviderTest.java
5b6e830d6e
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/FeedResourceProviderTest.java
5cf9b056ea
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/GroupResourceProviderTest.java
bbfa2d8503
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HostComponentProcessResourceProviderTest.java
5a7460d4c1
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HostComponentResourceProviderTest.java
7e32c15991
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HostResourceProviderTest.java
fd28081944
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HostStackVersionResourceProviderTest.java
6c95c53e5b
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/InstanceResourceProviderTest.java
ba6793989e
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/JMXHostProviderTest.java
e19ad29453
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/JobResourceProviderTest.java
6fd1a238ae
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/KerberosDescriptorResourceProviderTest.java
ca8127e42f
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/MemberResourceProviderTest.java
39ba4b9fe3
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RequestResourceProviderTest.java
c0695b12d6
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RequestScheduleResourceProviderTest.java
6d4f72d9ad
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RootServiceComponentResourceProviderTest.java
222340b4e7
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RootServiceHostComponentResourceProviderTest.java
ce3656c4ab
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RootServiceResourceProviderTest.java
96bc7c9674
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StackAdvisorResourceProviderTest.java
05232eac49
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StackArtifactResourceProviderTest.java
21df88d545
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StackConfigurationDependencyResourceProviderTest.java
7c88852f48
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StackConfigurationResourceProviderTest.java
9c48ad0d23
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StackDependencyResourceProviderTest.java
f35015348f
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StackLevelConfigurationResourceProviderTest.java
e9742bdfb1
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StackResourceProviderTest.java
4281e3372e
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StackServiceResourceProviderTest.java
2a2ef0b0b7
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/TargetClusterResourceProviderTest.java
492c012c7e
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/TaskResourceProviderTest.java
365d408ff6
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/TestIvoryProviderModule.java
90f10118d4
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java
d6b1ab3766
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UserResourceProviderDBTest.java
c4f0f349fb
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UserResourceProviderTest.java
9efad8a54d
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ValidationResourceProviderTest.java
c639d1fcdc
Diff: https://reviews.apache.org/r/63516/diff/1/
Testing
-------
tests do not pass yet, also on deploy get errors in some places.
Fixing mistakes
Thanks,
Dmitro Lisnichenko
