----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63444/#review190142 -----------------------------------------------------------
Ship it! Ship It! - Vitalyi Brodetskyi On Лис. 2, 2017, 1:31 після полудня, Andrew Onischuk wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63444/ > ----------------------------------------------------------- > > (Updated Лис. 2, 2017, 1:31 після полудня) > > > Review request for Ambari, Attila Doroszlai, Myroslav Papirkovskyy, and Sid > Wagle. > > > Bugs: AMBARI-22341 > https://issues.apache.org/jira/browse/AMBARI-22341 > > > Repository: ambari > > > Description > ------- > > Previously we had a bug/hack where alerts used some configurations (like > hostLevelParams,commandParams etc.) from the information saved by status > commands. > > Now the achitecture changed, we don't have this hack in place anymore. This > requires a non-hacky solution. Meaning alerts should be able to access > configurations outside of 'configurations' dictionary. > > > Diffs > ----- > > ambari-agent/src/main/python/ambari_agent/AlertSchedulerHandler.py > 3e2a55b849 > ambari-agent/src/main/python/ambari_agent/ClusterCache.py b924420f8b > ambari-agent/src/main/python/ambari_agent/ClusterConfigurationCache.py > 77ca4c1852 > ambari-agent/src/main/python/ambari_agent/CustomServiceOrchestrator.py > 1cf02d1e67 > ambari-agent/src/main/python/ambari_agent/InitializerModule.py 2c8021844f > ambari-agent/src/main/python/ambari_agent/alerts/base_alert.py 79a686ff66 > ambari-agent/src/main/python/ambari_agent/alerts/metric_alert.py da49d2ac35 > ambari-agent/src/main/python/ambari_agent/alerts/port_alert.py 36425500dd > ambari-agent/src/main/python/ambari_agent/alerts/script_alert.py 301e4401f9 > ambari-agent/src/main/python/ambari_agent/alerts/web_alert.py 0e400f75e3 > > > Diff: https://reviews.apache.org/r/63444/diff/2/ > > > Testing > ------- > > mvn clean test > > > Thanks, > > Andrew Onischuk > >
