----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63695/#review190578 -----------------------------------------------------------
Should have a test. ambari-server/src/main/java/org/apache/ambari/server/checks/CheckDescription.java Lines 331 (patched) <https://reviews.apache.org/r/63695/#comment268056> Should be a cluster check - this isn't specific to any service (even though core-site is associated with HDFS) ambari-server/src/main/java/org/apache/ambari/server/checks/CheckDescription.java Lines 332 (patched) <https://reviews.apache.org/r/63695/#comment268053> "LZO Codec Check" ambari-server/src/main/java/org/apache/ambari/server/checks/LZOCheck.java Lines 34-35 (patched) <https://reviews.apache.org/r/63695/#comment268058> Copy error :) ambari-server/src/main/java/org/apache/ambari/server/checks/LZOCheck.java Lines 70-72 (patched) <https://reviews.apache.org/r/63695/#comment268055> Elsewhere in the code "io.compression.codecs" is checked to see if it contains "com.hadoop.compression.lzo" We should check that one first as it's more consistent with the other checks. ambari-server/src/main/java/org/apache/ambari/server/checks/LZOCheck.java Lines 76 (patched) <https://reviews.apache.org/r/63695/#comment268057> Not service-specific - Nate Cole On Nov. 9, 2017, 5:15 a.m., Dmitro Lisnichenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63695/ > ----------------------------------------------------------- > > (Updated Nov. 9, 2017, 5:15 a.m.) > > > Review request for Ambari, Jonathan Hurley and Nate Cole. > > > Bugs: AMBARI-22387 > https://issues.apache.org/jira/browse/AMBARI-22387 > > > Repository: ambari > > > Description > ------- > > Ambari has removed its native support of distributing and installing LZO when > the LZO codecs are enabled in {{core-site}}. For existing clusters where LZO > is enabled, this means that performing an upgrade will now require manual > user intervention to get the LZO packages installed. > > A pre-upgrade check should be created which checks to see if LZO is enabled > in the cluster and then produces a {{WARNING}} to the user letting them know > that before upgrading, they'd need to distribute the appropriate LZO packages. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/checks/CheckDescription.java > f5e4ff9061 > ambari-server/src/main/java/org/apache/ambari/server/checks/LZOCheck.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/63695/diff/2/ > > > Testing > ------- > > checking > > > Thanks, > > Dmitro Lisnichenko > >
