----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63653/#review190612 -----------------------------------------------------------
Ship it! Ship It! - Jayush Luniya On Nov. 9, 2017, 12:16 a.m., Vitalyi Brodetskyi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63653/ > ----------------------------------------------------------- > > (Updated Nov. 9, 2017, 12:16 a.m.) > > > Review request for Ambari, Jayush Luniya, Myroslav Papirkovskyy, Madhuvanthi > Radhakrishnan, and Swapan Shridhar. > > > Bugs: AMBARI-22249 > https://issues.apache.org/jira/browse/AMBARI-22249 > > > Repository: ambari > > > Description > ------- > > Added id column for service group dependency. > Tested and fixed cross cluster mapping > Did some code cleanup > > P.S. I've added changes only for postgres .sql file. After First review, if > main part is ok, i will add changes and test other dbs. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/api/services/ServiceGroupService.java > 0638a06 > > ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceGroupDependencyRequest.java > e9cf937 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceGroupDependencyResourceProvider.java > 78610d2 > > ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ServiceGroupDAO.java > 63e78d6 > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ServiceGroupDependencyEntity.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ServiceGroupEntity.java > 1bcdd80 > ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java > 2193c3a > > ambari-server/src/main/java/org/apache/ambari/server/state/ServiceGroup.java > 3d59c96 > > ambari-server/src/main/java/org/apache/ambari/server/state/ServiceGroupImpl.java > 7737c0d > > ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java > 881f172 > ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql 36ff3b7 > ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 70a6543 > ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 7c5f0fd > ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql dfef1ce > ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 870555d > ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 641b959 > ambari-server/src/main/resources/META-INF/persistence.xml 009ecd5 > > > Diff: https://reviews.apache.org/r/63653/diff/2/ > > > Testing > ------- > > > Thanks, > > Vitalyi Brodetskyi > >
