----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63713/#review190701 -----------------------------------------------------------
Ship it! Ship It! - Dmitro Lisnichenko On Nov. 10, 2017, 3:43 a.m., Nate Cole wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63713/ > ----------------------------------------------------------- > > (Updated Nov. 10, 2017, 3:43 a.m.) > > > Review request for Ambari, Dmitro Lisnichenko and Jonathan Hurley. > > > Bugs: AMBARI-22411 > https://issues.apache.org/jira/browse/AMBARI-22411 > > > Repository: ambari > > > Description > ------- > > Small refactor to pass StackID instead of RepositoryVersionEntity, negating > the check that made this call fail. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java > d8712f2c75 > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java > 5ea4bbdf3d > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java > 1ec790f7cc > > ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_packages.json > 23c6d32dff > > ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerImplTest.java > c80620f6a3 > > > Diff: https://reviews.apache.org/r/63713/diff/1/ > > > Testing > ------- > > Manual. > Unit tests pending. Mostly verify that existing tests continue to work > without error. > > > Thanks, > > Nate Cole > >
