----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63734/#review190730 -----------------------------------------------------------
Ship it! Ship It! - Aleksandr Kovalenko On Ноя. 10, 2017, 4:19 п.п., Andrii Babiichuk wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63734/ > ----------------------------------------------------------- > > (Updated Ноя. 10, 2017, 4:19 п.п.) > > > Review request for Ambari and Aleksandr Kovalenko. > > > Bugs: AMBARI-22416 > https://issues.apache.org/jira/browse/AMBARI-22416 > > > Repository: ambari > > > Description > ------- > > 1. Checkboxes in multiselect, labels of dropdown filter buttons etc. should > pick up currently selected value even if it's set from outside the form > 2. All the tabs should have their own isolated filtering options, so that > filters application on one tab doesn't affect other tab > > > Diffs > ----- > > ambari-logsearch/ambari-logsearch-web/src/app/app.module.ts 56562df > ambari-logsearch/ambari-logsearch-web/src/app/classes/filtering.ts dde144b > ambari-logsearch/ambari-logsearch-web/src/app/classes/models/app-state.ts > 2c5c083 > ambari-logsearch/ambari-logsearch-web/src/app/classes/models/node-item.ts > PRE-CREATION > ambari-logsearch/ambari-logsearch-web/src/app/classes/models/node.ts > a14e51a > ambari-logsearch/ambari-logsearch-web/src/app/classes/models/store.ts > d912b35 > ambari-logsearch/ambari-logsearch-web/src/app/classes/models/tab.ts bb8028a > ambari-logsearch/ambari-logsearch-web/src/app/components/app.component.ts > 4de47ea > > ambari-logsearch/ambari-logsearch-web/src/app/components/dropdown-button/dropdown-button.component.html > 798a609 > > ambari-logsearch/ambari-logsearch-web/src/app/components/dropdown-button/dropdown-button.component.spec.ts > f11ca09 > > ambari-logsearch/ambari-logsearch-web/src/app/components/dropdown-button/dropdown-button.component.ts > 0bf4422 > > ambari-logsearch/ambari-logsearch-web/src/app/components/dropdown-list/dropdown-list.component.html > 5de78ad > > ambari-logsearch/ambari-logsearch-web/src/app/components/dropdown-list/dropdown-list.component.spec.ts > 5455e67 > > ambari-logsearch/ambari-logsearch-web/src/app/components/filter-button/filter-button.component.spec.ts > 3e40455 > > ambari-logsearch/ambari-logsearch-web/src/app/components/filter-button/filter-button.component.ts > 2c8ecd7 > > ambari-logsearch/ambari-logsearch-web/src/app/components/filter-dropdown/filter-dropdown.component.spec.ts > c294e8e > > ambari-logsearch/ambari-logsearch-web/src/app/components/filter-dropdown/filter-dropdown.component.ts > 9e5a6f1 > > ambari-logsearch/ambari-logsearch-web/src/app/components/filters-panel/filters-panel.component.html > fa739a4 > > ambari-logsearch/ambari-logsearch-web/src/app/components/filters-panel/filters-panel.component.spec.ts > 0bb0204 > > ambari-logsearch/ambari-logsearch-web/src/app/components/filters-panel/filters-panel.component.ts > 9601a0e > > ambari-logsearch/ambari-logsearch-web/src/app/components/log-context/log-context.component.spec.ts > 4e9bdc9 > > ambari-logsearch/ambari-logsearch-web/src/app/components/logs-container/logs-container.component.spec.ts > 0a9418f > > ambari-logsearch/ambari-logsearch-web/src/app/components/logs-container/logs-container.component.ts > 21949f1 > > ambari-logsearch/ambari-logsearch-web/src/app/components/logs-list/logs-list.component.html > 10f4af1 > > ambari-logsearch/ambari-logsearch-web/src/app/components/logs-list/logs-list.component.spec.ts > 8ee4ca3 > > ambari-logsearch/ambari-logsearch-web/src/app/components/logs-list/logs-list.component.ts > 017bc82 > > ambari-logsearch/ambari-logsearch-web/src/app/components/menu-button/menu-button.component.spec.ts > 261e213 > > ambari-logsearch/ambari-logsearch-web/src/app/components/menu-button/menu-button.component.ts > 5932e1b > > ambari-logsearch/ambari-logsearch-web/src/app/components/pagination-controls/pagination-controls.component.ts > 81676a9 > > ambari-logsearch/ambari-logsearch-web/src/app/components/pagination/pagination.component.html > 679a7e5 > > ambari-logsearch/ambari-logsearch-web/src/app/components/pagination/pagination.component.spec.ts > ff8675d > > ambari-logsearch/ambari-logsearch-web/src/app/components/pagination/pagination.component.ts > cc5589f > > ambari-logsearch/ambari-logsearch-web/src/app/components/search-box/search-box.component.ts > 5520310 > > ambari-logsearch/ambari-logsearch-web/src/app/components/time-range-picker/time-range-picker.component.html > 973db61 > > ambari-logsearch/ambari-logsearch-web/src/app/components/time-range-picker/time-range-picker.component.spec.ts > 7612cc3 > > ambari-logsearch/ambari-logsearch-web/src/app/components/time-range-picker/time-range-picker.component.ts > af4933a > > ambari-logsearch/ambari-logsearch-web/src/app/components/timezone-picker/timezone-picker.component.spec.ts > 53afc47 > > ambari-logsearch/ambari-logsearch-web/src/app/services/component-actions.service.spec.ts > e6a02c0 > > ambari-logsearch/ambari-logsearch-web/src/app/services/component-actions.service.ts > c483cd8 > > ambari-logsearch/ambari-logsearch-web/src/app/services/component-generator.service.spec.ts > 5dc38b4 > > ambari-logsearch/ambari-logsearch-web/src/app/services/filtering.service.spec.ts > 2b3e326 > ambari-logsearch/ambari-logsearch-web/src/app/services/filtering.service.ts > 85dc408 > > ambari-logsearch/ambari-logsearch-web/src/app/services/logs-container.service.spec.ts > ee0e1e7 > > ambari-logsearch/ambari-logsearch-web/src/app/services/logs-container.service.ts > e187b00 > > ambari-logsearch/ambari-logsearch-web/src/app/services/utils.service.spec.ts > a4a0cf8 > ambari-logsearch/ambari-logsearch-web/src/app/services/utils.service.ts > 3448dd4 > > > Diff: https://reviews.apache.org/r/63734/diff/1/ > > > Testing > ------- > > Executed 203 of 203 SUCCESS (4.088 secs / 4.039 secs) > > > Thanks, > > Andrii Babiichuk > >
