----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63707/#review190832 -----------------------------------------------------------
Ship it! Ship It! - Nate Cole On Nov. 10, 2017, 6:24 a.m., Robert Levas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63707/ > ----------------------------------------------------------- > > (Updated Nov. 10, 2017, 6:24 a.m.) > > > Review request for Ambari, Attila Magyar, Balázs Bence Sári, Eugene > Chekanskiy, Jonathan Hurley, Nate Cole, Robert Nettleton, and Swapan Shridhar. > > > Bugs: AMBARI-22347 > https://issues.apache.org/jira/browse/AMBARI-22347 > > > Repository: ambari > > > Description > ------- > > Simplify Ambari configuration tables from AMBARI-21307. > > configuration_base and ambari_configuration tables were introduced in > AMBARI-21307; however, these tables are more complex than needed. Future > architecture changes will eventually negate the need to have a shard > configuration structure as proposed. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariConfigurationRequestSwagger.java > 5e8094e9c7 > > ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariConfigurationService.java > 38ae7669db > > ambari-server/src/main/java/org/apache/ambari/server/api/services/ldap/AmbariConfiguration.java > b5cc9212da > > ambari-server/src/main/java/org/apache/ambari/server/api/services/ldap/LdapConfigurationService.java > 13f8835655 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AmbariConfigurationResourceProvider.java > 4f4cc7070d > > ambari-server/src/main/java/org/apache/ambari/server/events/AmbariEvent.java > 0f9ff52147 > > ambari-server/src/main/java/org/apache/ambari/server/events/AmbariLdapConfigChangedEvent.java > 48799d793b > > ambari-server/src/main/java/org/apache/ambari/server/ldap/domain/AmbariLdapConfiguration.java > 8b26cd3e29 > > ambari-server/src/main/java/org/apache/ambari/server/ldap/service/AmbariLdapConfigurationProvider.java > c88d420e9a > > ambari-server/src/main/java/org/apache/ambari/server/ldap/service/ads/LdapConnectionTemplateFactory.java > 8467af08b6 > > ambari-server/src/main/java/org/apache/ambari/server/orm/dao/AmbariConfigurationDAO.java > 83293efb82 > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/AmbariConfigurationEntity.java > c9f4695469 > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/AmbariConfigurationEntityPK.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ConfigurationBaseEntity.java > 9ad30d7d1a > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/SchemaUpgradeHelper.java > 8812ef5bfc > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog300.java > d3e924e66c > ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql 7d634941d9 > ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql af17353ff3 > ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 89c7971303 > ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 3d2bd3a107 > ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql > 55a6c61017 > ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql e5e8af59c3 > ambari-server/src/main/resources/META-INF/persistence.xml 67eef705af > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AmbariConfigurationResourceProviderTest.java > c2a14218e7 > > ambari-server/src/test/java/org/apache/ambari/server/orm/dao/AmbariConfigurationDAOTest.java > PRE-CREATION > > ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog300Test.java > bd8f5cbd57 > > > Diff: https://reviews.apache.org/r/63707/diff/1/ > > > Testing > ------- > > Manually tested > > # Local test results: > > ``` > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 26:56 min > [INFO] Finished at: 2017-11-09T17:32:37-05:00 > [INFO] Final Memory: 98M/1957M > [INFO] > ------------------------------------------------------------------------ > ``` > > > # Jenkins test results: PENDING > > > Thanks, > > Robert Levas > >
