----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63683/#review190872 -----------------------------------------------------------
Ship it! Ship It! - Alexandr Antonenko On Nov. 10, 2017, 3:03 p.m., Jason Golieb wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63683/ > ----------------------------------------------------------- > > (Updated Nov. 10, 2017, 3:03 p.m.) > > > Review request for Ambari, Alexandr Antonenko, Andrii Tkach, Denys Buzhor, > Ishan Bhatt, Jaimin Jetly, Vivek Ratnavel Subramanian, and Yusaku Sako. > > > Bugs: AMBARI-22385 > https://issues.apache.org/jira/browse/AMBARI-22385 > > > Repository: ambari > > > Description > ------- > > Make data persistence more consistent by using consistent method calls and > locating them in the same place for each step. This ensures that all steps > persist if the browser is reloaded. > > Also, improve data handling behavior when navigating backward in the wizard. > Now, the wizard tracks the saved state of all steps. If the user navigates > backward, there will be a warning displayed indicating that if they make > changes, they will lose saved data in later steps. If they don't change > anything, they can navigate back and forth without losing data. If they do > change something, the state of all later steps is reset. > > > Diffs > ----- > > .gitignore a40e61acbe4 > ambari-web/app/app.js 2526baa0047 > ambari-web/app/controllers/installer.js 5dd09414804 > ambari-web/app/controllers/main/host/add_controller.js 6b158c131ee > ambari-web/app/controllers/main/service/add_controller.js c11bcf267a4 > ambari-web/app/controllers/wizard.js 540cc638eb2 > ambari-web/app/controllers/wizard/configureDownload_controller.js > f3a8b1b588a > ambari-web/app/controllers/wizard/downloadProducts_controller.js > 165debbfb95 > ambari-web/app/controllers/wizard/selectMpacks_controller.js 9ab5a125f55 > ambari-web/app/controllers/wizard/step2_controller.js 05813e28b3a > ambari-web/app/controllers/wizard/step3_controller.js 2c61e02ea76 > ambari-web/app/controllers/wizard/step5_controller.js 873665267a9 > ambari-web/app/controllers/wizard/step6_controller.js 68ec3edf8de > ambari-web/app/controllers/wizard/step7_controller.js 3def063ac00 > ambari-web/app/controllers/wizard/step8_controller.js 0c72295d921 > ambari-web/app/messages.js 82adc8082b9 > ambari-web/app/mixins/wizard/assign_master_components.js 84a56f1d56b > ambari-web/app/routes/installer.js 5899ff3d545 > ambari-web/app/templates/common/assign_master_components.hbs a47e3f631a9 > ambari-web/app/templates/wizard/selectMpacks.hbs dd55ff307a6 > ambari-web/app/templates/wizard/selectMpacks/mpack.hbs aea598e3829 > ambari-web/app/templates/wizard/selectMpacks/selectedMpackVersion.hbs > cba1177052f > ambari-web/app/templates/wizard/step2.hbs b4ee25c4113 > ambari-web/app/templates/wizard/step3.hbs b480fd317c5 > ambari-web/app/templates/wizard/step6.hbs 5741f09f36a > ambari-web/app/views.js 1ef0b62321b > ambari-web/app/views/wizard/selectMpacks/mpack_view.js 9c22eb98d76 > ambari-web/app/views/wizard/selectMpacks/selectedMpackVersion_view.js > ca503d78510 > ambari-web/app/views/wizard/selectMpacks_view.js 3dc4ec05166 > ambari-web/app/views/wizard/step2_view.js 6bbda30625e > ambari-web/app/views/wizard/step6_view.js ab37245d9b8 > ambari-web/test/controllers/installer_test.js f581d91857d > ambari-web/test/controllers/main/host/add_controller_test.js 089d0182d76 > ambari-web/test/controllers/main/service/add_controller_test.js 1119176977a > ambari-web/test/controllers/wizard/step5_test.js 57c33b23afd > ambari-web/test/controllers/wizard/step6_test.js 85b4fab283e > ambari-web/test/controllers/wizard/step8_test.js fc977b764c2 > ambari-web/test/views/wizard/step2_view_test.js 93939682a7d > ambari-web/test/views/wizard/step6_view_test.js 7a4dc9f2d3d > > > Diff: https://reviews.apache.org/r/63683/diff/1/ > > > Testing > ------- > > 20262 passing (23s) > 124 pending > > This also resolved outstanding unit tests from AMBARI-22311 > > > Thanks, > > Jason Golieb > >
