----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63787/#review190921 -----------------------------------------------------------
Fix it, then Ship it! ambari-metrics/ambari-metrics-anomaly-detection-service/conf/unix/log4j.properties Lines 25 (patched) <https://reviews.apache.org/r/63787/#comment268488> This can be valid default: /var/log/ambari-metrics-anomaly-detection/ambari-metrics-admanager.log ambari-metrics/ambari-metrics-anomaly-detection-service/src/main/scala/org/apache/ambari/metrics/adservice/leveldb/LevelDBDatasource.scala Line 44 (original), 55 (patched) <https://reviews.apache.org/r/63787/#comment268489> why get.. vs verb for behavior spec? - Sid Wagle On Nov. 14, 2017, 6:16 a.m., Aravindan Vijayan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63787/ > ----------------------------------------------------------- > > (Updated Nov. 14, 2017, 6:16 a.m.) > > > Review request for Ambari, Jayush Luniya and Sid Wagle. > > > Bugs: AMBARI-22437 > https://issues.apache.org/jira/browse/AMBARI-22437 > > > Repository: ambari > > > Description > ------- > > Goals > Add a component called Anomaly-Detector in Ambari Metrics Service. > Create scripts to start/stop the component > Configuration management for Anomaly-Detector component. > Create Ambari stack scripts to manage lifecycle of the component - install, > start, stop. > > > Diffs > ----- > > > ambari-metrics/ambari-metrics-anomaly-detection-service/conf/unix/ambari-metrics-admanager.sh > PRE-CREATION > > ambari-metrics/ambari-metrics-anomaly-detection-service/conf/unix/log4j.properties > PRE-CREATION > ambari-metrics/ambari-metrics-anomaly-detection-service/pom.xml cfa8124 > > ambari-metrics/ambari-metrics-anomaly-detection-service/src/main/resources/config.yml > 299a472 > > ambari-metrics/ambari-metrics-anomaly-detection-service/src/main/scala/org/apache/ambari/metrics/adservice/app/AnomalyDetectionAppConfig.scala > aa20223 > > ambari-metrics/ambari-metrics-anomaly-detection-service/src/main/scala/org/apache/ambari/metrics/adservice/app/AnomalyDetectionAppModule.scala > 28b2880 > > ambari-metrics/ambari-metrics-anomaly-detection-service/src/main/scala/org/apache/ambari/metrics/adservice/configuration/HBaseConfiguration.scala > a7bbc66 > > ambari-metrics/ambari-metrics-anomaly-detection-service/src/main/scala/org/apache/ambari/metrics/adservice/configuration/MetricCollectorConfiguration.scala > 9418897 > > ambari-metrics/ambari-metrics-anomaly-detection-service/src/main/scala/org/apache/ambari/metrics/adservice/configuration/MetricDefinitionDBConfiguration.scala > 79a350c > > ambari-metrics/ambari-metrics-anomaly-detection-service/src/main/scala/org/apache/ambari/metrics/adservice/db/LevelDbStoreAccessor.scala > PRE-CREATION > > ambari-metrics/ambari-metrics-anomaly-detection-service/src/main/scala/org/apache/ambari/metrics/adservice/leveldb/LevelDBDatasource.scala > 6d185bf > > ambari-metrics/ambari-metrics-anomaly-detection-service/src/main/scala/org/apache/ambari/metrics/adservice/metadata/ADMetadataProvider.scala > 3bcf4b0 > > ambari-metrics/ambari-metrics-anomaly-detection-service/src/main/scala/org/apache/ambari/metrics/adservice/metadata/MetricDefinitionServiceImpl.scala > ffa9944 > > ambari-metrics/ambari-metrics-anomaly-detection-service/src/main/scala/org/apache/ambari/metrics/adservice/resource/AnomalyResource.scala > c941ac3 > > ambari-metrics/ambari-metrics-anomaly-detection-service/src/main/scala/org/apache/ambari/metrics/adservice/resource/MetricDefinitionResource.scala > aacea79 > > ambari-metrics/ambari-metrics-anomaly-detection-service/src/main/scala/org/apache/ambari/metrics/adservice/subsystem/trend/TrendAnomalyInstance.scala > 125da34 > > ambari-metrics/ambari-metrics-anomaly-detection-service/src/test/scala/org/apache/ambari/metrics/adservice/app/AnomalyDetectionAppConfigTest.scala > 104ccea > > ambari-metrics/ambari-metrics-anomaly-detection-service/src/test/scala/org/apache/ambari/metrics/adservice/app/DefaultADResourceSpecTest.scala > 65cf609 > > ambari-metrics/ambari-metrics-anomaly-detection-service/src/test/scala/org/apache/ambari/metrics/adservice/leveldb/LevelDBDataSourceTest.scala > 2ddb7b8 > > ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-admanager-config.xml > 489850f > > ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-admanager-env.xml > 99e93a6 > > ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-admanager-log4j.xml > PRE-CREATION > > ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/metainfo.xml > e80fae4 > > ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/ams.py > 4b960ff > > ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/params.py > a2bfe68 > > ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/status_params.py > 0a92cd2 > > ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/templates/admanager_config.yaml.j2 > 787aa3e > ambari-server/src/test/python/stacks/2.0.6/AMBARI_METRICS/test_admanager.py > PRE-CREATION > ambari-server/src/test/python/stacks/2.0.6/configs/default.json 43c184c > > ambari-server/src/test/python/stacks/2.0.6/configs/default_ams_embedded.json > eaaeeb5 > > > Diff: https://reviews.apache.org/r/63787/diff/1/ > > > Testing > ------- > > Manually Tested. > Relevant unit tests pass. > > > Thanks, > > Aravindan Vijayan > >
