----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63800/#review190961 -----------------------------------------------------------
Ship it! Ship It! - Tim Thorpe On Nov. 14, 2017, 4:46 p.m., Di Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63800/ > ----------------------------------------------------------- > > (Updated Nov. 14, 2017, 4:46 p.m.) > > > Review request for Ambari, Jonathan Hurley and Tim Thorpe. > > > Bugs: AMBARI-22431 > https://issues.apache.org/jira/browse/AMBARI-22431 > > > Repository: ambari > > > Description > ------- > > EU/RU does not create/load default of new config types when the source stack > and target stack is the same. This JIRA introduces a new config task type for > creating/loading defaults of a new config type when stack does not change > during EU/RU. This is particularly important for EU/RU of custom services > where their stack may not change at all. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java > 66f5bf9 > > ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/CreateAndConfigureAction.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/state/stack/UpgradePack.java > 56f13ab > > ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ClusterGrouping.java > 63d0993 > > ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/CreateAndConfigureTask.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/Task.java > 6ab2fd2 > ambari-server/src/main/resources/upgrade-pack.xsd 21606bd > > ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/CreateAndConfigureActionTest.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/63800/diff/1/ > > > Testing > ------- > > unit tests, patch Ambari 2.6 cluster with the changes, upgrade from HDP 2.6.2 > to 2.6.3, where zookeeper was modified to have zookeeper-fake that needs to > be created and configured during EU. > > > File Attachments > ---------------- > > config_type_tests_hdp_2.6 > > https://reviews.apache.org/media/uploaded/files/2017/11/14/06efe434-a4fa-4b74-bede-7293bb6e1bf5__config_type_tests_hdp_2.6.zip > > > Thanks, > > Di Li > >
