-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63805/
-----------------------------------------------------------
Review request for Ambari, Attila Magyar, Balázs Bence Sári, Eugene Chekanskiy,
Jonathan Hurley, Nate Cole, and Robert Nettleton.
Bugs: AMBARI-22418
https://issues.apache.org/jira/browse/AMBARI-22418
Repository: ambari
Description
-------
Make Ambari configuration API consistent with existing API.
The current API entry point (as of AMBARI-21307) is {{/api/v1/ambariconfigs}}.
This should be more inline with the existing entry point for Ambari server
related data... {{/api/v1/services/AMBARI/components/AMBARI_SERVER}}.
The new API entry point for Ambari server related configuration data should be
{{/api/v1/services/AMBARI/components/AMBARI_SERVER/configurations}}.
See https://issues.apache.org/jira/browse/AMBARI-22418 for details about the
new entryoint.
*NOTE*: This patch contains a fix for a stack advisor issue that was introduce
in the patch for https://issues.apache.org/jira/browse/AMBARI-22347.
*NOTE*: Many changes are due to moving `RootServiceResponseFactory.Services`
from an inner class to `RootService` and
`RootServiceResponseFactory.Components` from an inner class to `RootComponent`.
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java
f5fb6e9900
ambari-server/src/main/java/org/apache/ambari/server/api/resources/RootServiceComponentResourceDefinition.java
e8cb570c56
ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariConfigurationRequestSwagger.java
2dca9f55f4
ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariConfigurationResponseSwagger.java
c55ac1dd60
ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariConfigurationService.java
86ed666f41
ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java
46ee65abea
ambari-server/src/main/java/org/apache/ambari/server/api/services/RootServiceComponentConfigurationService.java
PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/api/services/RootServiceService.java
5afb7dc90c
ambari-server/src/main/java/org/apache/ambari/server/api/services/ldap/AmbariConfiguration.java
e9f0b1e1a4
ambari-server/src/main/java/org/apache/ambari/server/api/services/ldap/LdapConfigurationRequest.java
2e478c4329
ambari-server/src/main/java/org/apache/ambari/server/api/services/ldap/LdapConfigurationService.java
00c13f6cfa
ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/commands/StackAdvisorCommand.java
91edf867ae
ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java
1425e1bd32
ambari-server/src/main/java/org/apache/ambari/server/controller/MaintenanceStateHelper.java
d9a585f630
ambari-server/src/main/java/org/apache/ambari/server/controller/ResourceProviderFactory.java
711ae10f7e
ambari-server/src/main/java/org/apache/ambari/server/controller/RootComponent.java
PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/controller/RootService.java
PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/controller/RootServiceResponseFactory.java
ad9ed202dc
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java
1dc0841d19
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AmbariConfigurationResourceProvider.java
a24400dffd
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RootServiceComponentConfigurationResourceProvider.java
PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RootServiceComponentPropertyProvider.java
433c1fae90
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RootServiceComponentResourceProvider.java
3925aebdae
ambari-server/src/main/java/org/apache/ambari/server/controller/spi/Resource.java
78353735ac
ambari-server/src/main/java/org/apache/ambari/server/events/listeners/alerts/AlertReceivedListener.java
266c7e81c1
ambari-server/src/main/java/org/apache/ambari/server/events/listeners/alerts/AlertStateChangedListener.java
d5dc530394
ambari-server/src/main/java/org/apache/ambari/server/ldap/domain/AmbariLdapConfiguration.java
0c1ec0ae71
ambari-server/src/main/java/org/apache/ambari/server/ldap/domain/AmbariLdapConfigurationFactory.java
2b9f24be89
ambari-server/src/main/java/org/apache/ambari/server/ldap/service/AmbariLdapConfigurationProvider.java
b32d1ed9fb
ambari-server/src/main/java/org/apache/ambari/server/metadata/AmbariServiceAlertDefinitions.java
1e20571ab2
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/AlertDefinitionDAO.java
cda03f307b
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/AlertDispatchDAO.java
5c6a82ffcf
ambari-server/src/main/java/org/apache/ambari/server/state/alert/AlertDefinitionHash.java
15f7048ab0
ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java
9c0b0ca01a
ambari-server/src/main/java/org/apache/ambari/server/state/services/AmbariServerAlertService.java
d3237a94b8
ambari-server/src/test/java/org/apache/ambari/server/api/services/stackadvisor/commands/StackAdvisorCommandTest.java
959db1547b
ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java
7094caae87
ambari-server/src/test/java/org/apache/ambari/server/controller/RootServiceResponseFactoryTest.java
c27ef7e0dd
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AmbariConfigurationResourceProviderTest.java
a2ecb271ed
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RootServiceComponentPropertyProviderTest.java
a202516650
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RootServiceComponentResourceProviderTest.java
222340b4e7
ambari-server/src/test/java/org/apache/ambari/server/ldap/LdapModuleFunctionalTest.java
30f5e22ee0
ambari-server/src/test/java/org/apache/ambari/server/ldap/domain/TestAmbariLdapConfigurationFactory.java
aa26498d92
ambari-server/src/test/java/org/apache/ambari/server/ldap/service/AmbariLdapFacadeTest.java
db0e5a96ad
ambari-server/src/test/java/org/apache/ambari/server/ldap/service/ads/DefaultLdapAttributeDetectionServiceTest.java
09dea1c210
ambari-server/src/test/java/org/apache/ambari/server/ldap/service/ads/DefaultLdapConfigurationServiceTest.java
4d6d2a6a50
ambari-server/src/test/java/org/apache/ambari/server/metadata/AgentAlertDefinitionsTest.java
adaf236b3d
ambari-server/src/test/java/org/apache/ambari/server/orm/dao/AlertDefinitionDAOTest.java
d559e0c316
ambari-server/src/test/java/org/apache/ambari/server/state/alerts/AlertReceivedListenerTest.java
3ec6943d25
ambari-server/src/test/java/org/apache/ambari/server/state/alerts/AlertStateChangedEventTest.java
bc8222c7c8
Diff: https://reviews.apache.org/r/63805/diff/1/
Testing
-------
Manually tested the API and stack advisor.
# Local test results:
```
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 30:50 min
[INFO] Finished at: 2017-11-14T13:41:32-05:00
[INFO] Final Memory: 99M/1963M
[INFO] ------------------------------------------------------------------------
```
# Jenkins test results: PENDING
Thanks,
Robert Levas
