----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63838/#review191067 -----------------------------------------------------------
Fix it, then Ship it! ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java Lines 734-735 (patched) <https://reviews.apache.org/r/63838/#comment268661> I'd prefer type `Boolean` (and possibly default value of `Boolean.FALSE`). ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java Lines 5332 (patched) <https://reviews.apache.org/r/63838/#comment268659> Looks like this would throw NPE if the property `gpl.license.accepted` is not present in `ambari.properties`. How about using `Boolean.valueOf(String)`? - Attila Doroszlai On Nov. 15, 2017, 3:34 p.m., Andrew Onischuk wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63838/ > ----------------------------------------------------------- > > (Updated Nov. 15, 2017, 3:34 p.m.) > > > Review request for Ambari, Myroslav Papirkovskyy and Sid Wagle. > > > Bugs: AMBARI-22453 > https://issues.apache.org/jira/browse/AMBARI-22453 > > > Repository: ambari > > > Description > ------- > > * Ask the user if they are okay with installing GPL license software > * Surface the license agreement subtext, for now use placeholder > * Save the result in ambari.properties > * The user selection should be available through API for the client and > also stack scripts > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java > 91df506478 > > ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java > 0bd6af6611 > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java > d8712f2c75 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProvider.java > 0b048ad089 > ambari-server/src/main/python/ambari-server.py 60c60052cc > ambari-server/src/main/python/ambari_server/serverConfiguration.py > c7ac13476f > ambari-server/src/main/python/ambari_server/serverSetup.py c1643f2621 > > > Diff: https://reviews.apache.org/r/63838/diff/1/ > > > Testing > ------- > > mvn clean test > > > Thanks, > > Andrew Onischuk > >
