----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63916/#review191492 -----------------------------------------------------------
Thanks for reviews - Andrew Onischuk On Nov. 20, 2017, 10:35 a.m., Andrew Onischuk wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63916/ > ----------------------------------------------------------- > > (Updated Nov. 20, 2017, 10:35 a.m.) > > > Review request for Ambari, Attila Doroszlai, Jonathan Hurley, Myroslav > Papirkovskyy, Nate Cole, and Sid Wagle. > > > Bugs: AMBARI-22467 > https://issues.apache.org/jira/browse/AMBARI-22467 > > > Repository: ambari > > > Description > ------- > > Changes Summary: > - Do not install lzo if GPL license if not accepted, instead give out > logger.warning and skip > - Remove installation of lzo from metainfo.xml. Since we need to install lzo > on restart if lzo is enabled/license accepted, we still need to do this in > Python code. No need to duplicate. > Clients will also use that code during install. > - Move function get_lzo_packages to lzo_utils.py > - Add code for Yarn, MR2, Hive to install lzo, edit existing code to install > lzo for HDFS,Oozie to use lzo_utils.py > > Notes: > - Impl is Patch Upgrade friendly as uses the same code to detect > {stack_version} as all the other packages. That code (not implemented here) > gets version depending component specific repo info not stack specific. > > > Diffs > ----- > > > ambari-common/src/main/python/resource_management/libraries/functions/__init__.py > f144b2da32266782437d6dad3f6c76de7e8106cd > > ambari-common/src/main/python/resource_management/libraries/functions/get_lzo_packages.py > cfbb7d81e82a08acf187999b95b02bca8b8fb54a > > ambari-common/src/main/python/resource_management/libraries/functions/package_conditions.py > 31e78b9e60b40513e8d107d45ed2fbf4620ce9db > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/metainfo.xml > 2df1b9f6476c52deab49e24028d10817c83af8ef > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs.py > 6f702d3616f0991862cd7e020e7e18f3b389883b > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/install_params.py > fe488c3004f934e00030e1b9d8952fd42d71f8e3 > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_linux.py > 5ca012b7966c044c4e5971bb400517f82aaa95c6 > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py > abbe59ed9f9ff4922da78a31661308804b517893 > > ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie.py > 7d2260318420e869f4011d54117e8233a6cd9928 > > ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/params_linux.py > cd1f7ad36fbda06d86effb7c1d04edbc20a1a876 > > ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/yarn.py > f6e8391a54a03db3e4209edf5d2089eb86c14fd3 > ambari-server/src/main/resources/stacks/HDP/2.2/services/HDFS/metainfo.xml > 07a9ef8e943dc47428c07c60c872580c141c5dbc > ambari-server/src/main/resources/stacks/HDP/2.3/services/HDFS/metainfo.xml > 63e85e363f295627bba4e3b30328bb7f521cb9b3 > ambari-server/src/test/python/stacks/2.2/configs/oozie-upgrade.json > 86ca03a4a3101e646f265b5dca6e32bb179c9856 > > > Diff: https://reviews.apache.org/r/63916/diff/2/ > > > Testing > ------- > > mvn clean test > > > Thanks, > > Andrew Onischuk > >
