----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63962/#review191550 -----------------------------------------------------------
Fix it, then Ship it! ambari-common/src/main/python/resource_management/libraries/functions/copy_tarball.py Lines 96 (patched) <https://reviews.apache.org/r/63962/#comment269396> better to use function from the sudo module here ambari-common/src/main/python/resource_management/libraries/functions/copy_tarball.py Lines 100 (patched) <https://reviews.apache.org/r/63962/#comment269397> we need to use sudo module, as agent may work not from root, thus we can get here "permission denied" or not found ambari-common/src/main/python/resource_management/libraries/functions/copy_tarball.py Lines 162 (patched) <https://reviews.apache.org/r/63962/#comment269398> better to use function from sudo module ambari-common/src/main/python/resource_management/libraries/functions/copy_tarball.py Lines 181 (patched) <https://reviews.apache.org/r/63962/#comment269399> here native python call is fine, as we operating with our temporary created directory and have full ownership on it - Dmytro Grinenko On Nov. 20, 2017, 7:27 p.m., Jonathan Hurley wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63962/ > ----------------------------------------------------------- > > (Updated Nov. 20, 2017, 7:27 p.m.) > > > Review request for Ambari, Dmytro Grinenko and Nate Cole. > > > Bugs: AMBARI-22486 > https://issues.apache.org/jira/browse/AMBARI-22486 > > > Repository: ambari > > > Description > ------- > > If LZO is enabled and has been opted-in, then the Tez and MapReduce tarballs > should have LZO added to them. > > > Diffs > ----- > > > ambari-common/src/main/python/resource_management/libraries/functions/copy_tarball.py > b05c97cdfe > > ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/tez.py > dfa650110d > > ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/configuration-mapred/mapred-site.xml > 3438c45527 > > ambari-server/src/main/resources/stacks/HDP/2.2/services/TEZ/configuration/tez-site.xml > 4ffb7a49a4 > > ambari-server/src/main/resources/stacks/HDP/2.2/services/YARN/configuration-mapred/mapred-site.xml > 084e91254c > ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/config-upgrade.xml > 45380728e3 > > > Diff: https://reviews.apache.org/r/63962/diff/1/ > > > Testing > ------- > > Manual testing. > > > Thanks, > > Jonathan Hurley > >
