----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64059/#review191827 -----------------------------------------------------------
ambari-infra/ambari-infra-manager/src/test/java/org/apache/ambari/infra/job/archive/LocalDocumentItemWriterTest.java Lines 85 (patched) <https://reviews.apache.org/r/64059/#comment269769> you can use org.apache.commons.io.FileUtils>>readLines if you have commons-io as a dependency - Attila Magyar On Nov. 24, 2017, 9:31 a.m., Krisztian Kasa wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64059/ > ----------------------------------------------------------- > > (Updated Nov. 24, 2017, 9:31 a.m.) > > > Review request for Ambari, Attila Magyar, Oliver Szabo, and Robert Nettleton. > > > Bugs: AMBARI-22514 > https://issues.apache.org/jira/browse/AMBARI-22514 > > > Repository: ambari > > > Description > ------- > > Initial implementation of Schedulable document deletion & archiving for Infra > Solr > ================================================================================== > > Spring bacth job for > > * exporting solr documents from hadoop_logs collection > * saving the documents to filesystem. All document is converted to json and > written into new line. > * compress each file using tar.gz > * job can be started using ambari-infra-manager api and parameters can be > overwritten > * s3 upload support (not used yet) > > > Diffs > ----- > > ambari-infra/ambari-infra-manager/pom.xml aa86da82b2 > > ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/archive/CompositeFileAction.java > PRE-CREATION > > ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/archive/Document.java > PRE-CREATION > > ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/archive/DocumentDestination.java > PRE-CREATION > > ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/archive/DocumentExportConfiguration.java > PRE-CREATION > > ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/archive/DocumentExportJobListener.java > PRE-CREATION > > ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/archive/DocumentExportProperties.java > PRE-CREATION > > ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/archive/DocumentExportStepListener.java > PRE-CREATION > > ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/archive/DocumentExporter.java > PRE-CREATION > > ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/archive/DocumentItemReader.java > PRE-CREATION > > ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/archive/DocumentItemWriter.java > PRE-CREATION > > ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/archive/DocumentIterator.java > PRE-CREATION > > ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/archive/DocumentSource.java > PRE-CREATION > > ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/archive/FileAction.java > PRE-CREATION > > ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/archive/HadoopLogSource.java > PRE-CREATION > > ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/archive/LocalDocumentItemWriter.java > PRE-CREATION > > ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/archive/S3Properties.java > PRE-CREATION > > ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/archive/S3Uploader.java > PRE-CREATION > > ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/archive/SolrDocumentIterator.java > PRE-CREATION > > ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/archive/SolrDocumentSource.java > PRE-CREATION > > ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/archive/TarGzCompressor.java > PRE-CREATION > > ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/manager/JobManager.java > fc0a4f71db > > ambari-infra/ambari-infra-manager/src/main/resources/infra-manager.properties > 81623764da > > ambari-infra/ambari-infra-manager/src/test/java/org/apache/ambari/infra/job/archive/DocumentExporterTest.java > PRE-CREATION > > ambari-infra/ambari-infra-manager/src/test/java/org/apache/ambari/infra/job/archive/DocumentItemReaderTest.java > PRE-CREATION > > ambari-infra/ambari-infra-manager/src/test/java/org/apache/ambari/infra/job/archive/LocalDocumentItemWriterTest.java > PRE-CREATION > ambari-infra/pom.xml e4b6a7601f > ambari-logsearch/docker/test-config/logfeeder/logfeeder.properties > fb7ddf2845 > > > Diff: https://reviews.apache.org/r/64059/diff/2/ > > > Testing > ------- > > * unit tests > * manual test using docker-compose > > > Thanks, > > Krisztian Kasa > >
