----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64043/#review191847 -----------------------------------------------------------
Ship it! Ship It! - Jonathan Hurley On Nov. 22, 2017, 7:55 p.m., Amarnath reddy pappu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64043/ > ----------------------------------------------------------- > > (Updated Nov. 22, 2017, 7:55 p.m.) > > > Review request for Ambari, Jonathan Hurley and Nate Cole. > > > Bugs: AMBARI-22458 > https://issues.apache.org/jira/browse/AMBARI-22458 > > > Repository: ambari > > > Description > ------- > > SNMP Trap should contain sysuptime field filled: > > Calculating the Ambari server up time and setting it in TRAP. > > Fix: calculating the uptime using below call. > > RuntimeMXBean runtimeMXBean = ManagementFactory.getRuntimeMXBean(); > long uptimeInMillis = runtimeMXBean.getUptime(); > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/notifications/dispatchers/AmbariSNMPDispatcher.java > 1eb9977 > > > Diff: https://reviews.apache.org/r/64043/diff/1/ > > > Testing > ------- > > I have done basic testing locally by printing the uptimeInMillis in the logs > - I have provided this patch to one of the customer and they confirmed that > this patch works fine and could see sysuptime in target SNMP Target server. > > > Thanks, > > Amarnath reddy pappu > >
