----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64120/#review192029 -----------------------------------------------------------
Ship it! Ship It! - Aleksandr Kovalenko On Ноя. 28, 2017, 2:14 п.п., Andrii Babiichuk wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64120/ > ----------------------------------------------------------- > > (Updated Ноя. 28, 2017, 2:14 п.п.) > > > Review request for Ambari and Aleksandr Kovalenko. > > > Bugs: AMBARI-22531 > https://issues.apache.org/jira/browse/AMBARI-22531 > > > Repository: ambari > > > Description > ------- > > 1. Provide styles for search criteria labels (background color: #dddddd, > border-radius: 2px, font color: #666666, icon color: #666666). > 2. Provide filtering by all possible criteria, including the ones that have > separate filtering controls. > 3. User should be able to choose parameter value from list of available > options (if any). > 4. If user submits any text instead of selecting parameter name from > dropdown, filter by message should be applied. > 5. Pressing Backspace in case when parameter value text isn't yet typed > should erase the current filter condition. > 6. Add more internal padding to the search box entries, like 5 px top/bottom, > and 2px left/right. > > > Diffs > ----- > > ambari-logsearch/ambari-logsearch-web/src/app/classes/filtering.ts 2a7205f > ambari-logsearch/ambari-logsearch-web/src/app/classes/models/app-state.ts > afed497 > > ambari-logsearch/ambari-logsearch-web/src/app/classes/queries/audit-logs-query-params.ts > 509fa04 > > ambari-logsearch/ambari-logsearch-web/src/app/classes/queries/service-logs-truncated-query-params.ts > 6f9de16 > ambari-logsearch/ambari-logsearch-web/src/app/classes/string.ts > PRE-CREATION > > ambari-logsearch/ambari-logsearch-web/src/app/components/filters-panel/filters-panel.component.html > 2d327a6 > > ambari-logsearch/ambari-logsearch-web/src/app/components/filters-panel/filters-panel.component.spec.ts > 1f7e8db > > ambari-logsearch/ambari-logsearch-web/src/app/components/filters-panel/filters-panel.component.ts > b41f7cd > > ambari-logsearch/ambari-logsearch-web/src/app/components/logs-container/logs-container.component.html > f34dd15 > > ambari-logsearch/ambari-logsearch-web/src/app/components/logs-container/logs-container.component.ts > b06cfa4 > ambari-logsearch/ambari-logsearch-web/src/app/components/mixins.less > 5fa265b > > ambari-logsearch/ambari-logsearch-web/src/app/components/search-box/search-box.component.html > 92f9520 > > ambari-logsearch/ambari-logsearch-web/src/app/components/search-box/search-box.component.less > f0a5ce0 > > ambari-logsearch/ambari-logsearch-web/src/app/components/search-box/search-box.component.ts > 18ff715 > ambari-logsearch/ambari-logsearch-web/src/app/components/variables.less > 7b7fcae > > ambari-logsearch/ambari-logsearch-web/src/app/services/component-actions.service.spec.ts > 6d43ff1 > > ambari-logsearch/ambari-logsearch-web/src/app/services/component-actions.service.ts > e796183 > > ambari-logsearch/ambari-logsearch-web/src/app/services/component-generator.service.spec.ts > a161190 > > ambari-logsearch/ambari-logsearch-web/src/app/services/logs-container.service.spec.ts > 47cb25d > > ambari-logsearch/ambari-logsearch-web/src/app/services/logs-container.service.ts > a715adc > ambari-logsearch/ambari-logsearch-web/src/app/services/utils.service.ts > 175b585 > > > Diff: https://reviews.apache.org/r/64120/diff/1/ > > > Testing > ------- > > Executed 211 of 211 SUCCESS (4.747 secs / 4.683 secs) > > > Thanks, > > Andrii Babiichuk > >
