-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64089/
-----------------------------------------------------------
(Updated Nov. 29, 2017, 2:16 p.m.)
Review request for Ambari, Attila Magyar, Balázs Bence Sári, Eugene Chekanskiy,
Jonathan Hurley, Jayush Luniya, Nate Cole, Robert Nettleton, and Swapan
Shridhar.
Changes
-------
Addressed all reviewer concerns.
Bugs: AMBARI-22481
https://issues.apache.org/jira/browse/AMBARI-22481
Repository: ambari
Description
-------
Make Ambari configuration API consistent with existing API.
The current API entry point (as of AMBARI-21307) to set and test the LDAP
configuration is {{/api/v1/ldapconfigs}}. This should be more inline with the
existing entry point for Ambari server related data...
`/api/v1/services/AMBARI/components/AMBARI_SERVER`.
The new API entry point for Ambari server related configuration data should be
`/api/v1/services/AMBARI/components/AMBARI_SERVER/configurations`. For the
LDAP-specific configuration, the configuration category is
*"ldap-configuration"*.
See AMBARI-22481 for examples on using the API.
For testing the configuration, the following directives should be used:
* `op=test-connection`
* `op=test-attributes`
* `op=detect-attributes`
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/api/handlers/CreateHandler.java
b614c5e92f
ambari-server/src/main/java/org/apache/ambari/server/api/handlers/UpdateHandler.java
2f1af512be
ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java
fecaedc459
ambari-server/src/main/java/org/apache/ambari/server/api/services/RootServiceComponentConfigurationService.java
c7c37a6956
ambari-server/src/main/java/org/apache/ambari/server/api/services/ldap/AmbariConfiguration.java
7bac65ec83
ambari-server/src/main/java/org/apache/ambari/server/api/services/ldap/LdapConfigOperation.java
478d4ff188
ambari-server/src/main/java/org/apache/ambari/server/api/services/ldap/LdapConfigurationRequest.java
0e065e5f21
ambari-server/src/main/java/org/apache/ambari/server/api/services/ldap/LdapConfigurationService.java
22784cd599
ambari-server/src/main/java/org/apache/ambari/server/api/services/ldap/LdapRequestInfo.java
eeecfeec38
ambari-server/src/main/java/org/apache/ambari/server/api/services/serializers/JsonSerializer.java
0604d2bdc9
ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/commands/StackAdvisorCommand.java
4ec15ef7e4
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AmbariServerConfigurationCategory.java
PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AmbariServerConfigurationHandler.java
PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AmbariServerLDAPConfigurationHandler.java
PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/OperationStatusMetaData.java
PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RootServiceComponentConfigurationHandler.java
PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RootServiceComponentConfigurationHandlerFactory.java
PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RootServiceComponentConfigurationResourceProvider.java
78078652f0
ambari-server/src/main/java/org/apache/ambari/server/ldap/LdapModule.java
089da1df7b
ambari-server/src/main/java/org/apache/ambari/server/ldap/domain/AmbariLdapConfigKeys.java
da655adb57
ambari-server/src/main/java/org/apache/ambari/server/ldap/domain/AmbariLdapConfiguration.java
6c466bae37
ambari-server/src/main/java/org/apache/ambari/server/ldap/domain/AmbariLdapConfigurationFactory.java
aafd204abc
ambari-server/src/main/java/org/apache/ambari/server/ldap/service/AmbariLdapConfigurationProvider.java
ac9c1bc8ee
ambari-server/src/main/java/org/apache/ambari/server/ldap/service/AmbariLdapFacade.java
0118840b73
ambari-server/src/main/java/org/apache/ambari/server/ldap/service/LdapFacade.java
ef84d1bb2b
ambari-server/src/main/java/org/apache/ambari/server/ldap/service/ads/DefaultLdapAttributeDetectionService.java
a9a9b539f2
ambari-server/src/main/java/org/apache/ambari/server/ldap/service/ads/DefaultLdapConfigurationService.java
3f6995c48a
ambari-server/src/main/java/org/apache/ambari/server/ldap/service/ads/detectors/GroupMemberAttrDetector.java
8c34ef81aa
ambari-server/src/main/java/org/apache/ambari/server/ldap/service/ads/detectors/GroupNameAttrDetector.java
0315ef2b62
ambari-server/src/main/java/org/apache/ambari/server/ldap/service/ads/detectors/GroupObjectClassDetector.java
b681134b5a
ambari-server/src/main/java/org/apache/ambari/server/ldap/service/ads/detectors/UserGroupMemberAttrDetector.java
b34a2b2bfe
ambari-server/src/main/java/org/apache/ambari/server/ldap/service/ads/detectors/UserNameAttrDetector.java
dec445923a
ambari-server/src/main/java/org/apache/ambari/server/ldap/service/ads/detectors/UserObjectClassDetector.java
bf2f5b8a76
ambari-server/src/test/java/org/apache/ambari/server/api/services/stackadvisor/commands/StackAdvisorCommandTest.java
2afbf8aa87
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RootServiceComponentConfigurationResourceProviderTest.java
5016160c65
ambari-server/src/test/java/org/apache/ambari/server/ldap/LdapModuleFunctionalTest.java
3917cdf034
ambari-server/src/test/java/org/apache/ambari/server/ldap/domain/TestAmbariLdapConfigurationFactory.java
10822504e7
ambari-server/src/test/java/org/apache/ambari/server/ldap/service/AmbariLdapFacadeTest.java
97ce30eb6a
ambari-server/src/test/java/org/apache/ambari/server/ldap/service/ads/DefaultLdapAttributeDetectionServiceTest.java
a44bf7cadd
ambari-server/src/test/java/org/apache/ambari/server/ldap/service/ads/DefaultLdapConfigurationServiceTest.java
ec78e5662a
Diff: https://reviews.apache.org/r/64089/diff/2/
Changes: https://reviews.apache.org/r/64089/diff/1-2/
Testing
-------
Manually tested against various LDAP servers.
# Local test results:
```
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 29:17 min
[INFO] Finished at: 2017-11-27T14:10:40-05:00
[INFO] Final Memory: 99M/1996M
[INFO] ------------------------------------------------------------------------
```
# Jenkins test results:
```
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12899468/AMBARI-22481_trunk_01.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 6 new
or modified test files.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
ambari-server.
Console output:
https://builds.apache.org/job/Ambari-trunk-test-patch/12743//console
```
Thanks,
Robert Levas
