> On Nov. 30, 2017, 8:19 a.m., Andrew Onischuk wrote: > > ambari-server/src/main/python/ambari_server/serverConfiguration.py > > Line 1162 (original), 1157 (patched) > > <https://reviews.apache.org/r/64186/diff/3/?file=1904146#file1904146line1163> > > > > I think you might have broken silent flag to enable gpl by doing this. > > Andrew Onischuk wrote: > By doing so you should able to fix it. (should add default_value kwarg to > write_gpl_license_accepted. > > - if not get_silent() or options.accept_gpl: > - print 'Checking GPL software agreement...' > - write_gpl_license_accepted() > + print 'Checking GPL software agreement...' > + write_gpl_license_accepted(default_value=(get_silent() and > options.accept_gpl))
Ah it formats really bad. So I meant was to replace this: if not get_silent() or options.accept_gpl: print 'Checking GPL software agreement...' write_gpl_license_accepted() by this: print 'Checking GPL software agreement...' write_gpl_license_accepted(default_value=(get_silent() and options.accept_gpl)) - Andrew ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64186/#review192245 ----------------------------------------------------------- On Nov. 30, 2017, 12:20 a.m., Sid Wagle wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64186/ > ----------------------------------------------------------- > > (Updated Nov. 30, 2017, 12:20 a.m.) > > > Review request for Ambari, Andrew Onischuk, Jonathan Hurley, and Myroslav > Papirkovskyy. > > > Bugs: AMBARI-22555 > https://issues.apache.org/jira/browse/AMBARI-22555 > > > Repository: ambari > > > Description > ------- > > Presently the default is to accept GPL for LZO download. > > > Diffs > ----- > > ambari-server/src/main/python/ambari_server/serverConfiguration.py 8697e4c > ambari-server/src/main/python/ambari_server/serverUpgrade.py a864609 > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py > 3f8a772 > ambari-server/src/test/python/stacks/2.0.6/common/test_stack_advisor.py > e5adb19 > > > Diff: https://reviews.apache.org/r/64186/diff/3/ > > > Testing > ------- > > mvn clean test > > > Thanks, > > Sid Wagle > >
